Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baler directory check strictness #30

Closed
wigman opened this issue Dec 12, 2019 · 0 comments
Closed

Baler directory check strictness #30

wigman opened this issue Dec 12, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@wigman
Copy link

wigman commented Dec 12, 2019

Request to loosen up findMagentoRoot check requirements.

Currently Baler checks for these required directories:

  • app/
  • pub/
  • lib/
  • index.php

However, index.php is not necessary, while vendor probably is necessary (for the graph building later on).

The baler build should preferably only check for pub/static/frontend because that's the only place it needs to get data from, and it's enough to determine you are in the right directory.

For the baler graph method (when released) you could do a wider check, including the other directories.

1 - The error message could be more descriptive (currently says Could not find Magento store root from [X].
2 - The requirements could be reduced

Why is this important?

A lot of us devs out there use docker and run npm commands locally, not in the containers. So we usually don't have all these directories locally mounted/synced to the containers.
Especially lib/ and index.php are very rare to have synced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants