Fix naming conventions and optional/required fields in company GraphQL schema #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prabhuram93
reviewed
Oct 16, 2020
| children: [CompanyAclResource!] @doc(description: "An array of sub-resources.") | ||
| } | ||
|
|
||
| type CompanyRoleNameCheckResponse @doc(description: "Response object schema for a role name validation query.") { | ||
| isNameValid: Boolean @doc(description: "Role name validation result") | ||
| is_name_valid: Boolean @doc(description: "Role name validation result") |
There was a problem hiding this comment.
Not super important. Boolean can be made mandatory. (Boolean!)
prabhuram93
approved these changes
Oct 16, 2020
cpartica
approved these changes
Oct 22, 2020
melnikovi
changed the title
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fix naming conventions and optional/required fields.
Solution
Requested Reviewers