Skip to content

Introduce Category grid page #1525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Jul 7, 2020
Merged

Introduce Category grid page #1525

merged 25 commits into from
Jul 7, 2020

Conversation

Nazar65
Copy link
Member

@Nazar65 Nazar65 commented Jun 24, 2020 •
edited
Loading

Fixed Issues (if relevant)

  1. Fixes Add Category grid page #1481:Add Category grid page
  2. ...

Manual testing scenarios (*)

  1. Login to Admin panel
  2. Go to admin/media_gallery_catalog/category/index page

@Nazar65
Copy link
Member Author

Nazar65 commented Jun 24, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Jun 25, 2020

@magento run all tests

@gabrieldagama gabrieldagama self-assigned this Jun 25, 2020
@Nazar65
Copy link
Member Author

Nazar65 commented Jun 25, 2020

@magento run all tests

gabrieldagama
gabrieldagama suggested changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@gabrieldagama gabrieldagama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Nazar65, thanks for the PR it looks great! Please follow some comments below.

@Nazar65
Copy link
Member Author

Nazar65 commented Jun 25, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Jun 26, 2020

@magento run all tests

@Nazar65 Nazar65 changed the title [WIP] Introduce Category grid page Introduce Category grid page Jun 26, 2020
@Nazar65
Copy link
Member Author

Nazar65 commented Jun 26, 2020

@magento run all tests

@Nazar65 Nazar65 added the MFTF tests MFTF tests coverage label Jun 26, 2020
@Nazar65
Copy link
Member Author

Nazar65 commented Jun 26, 2020

@magento run all tests

gabrieldagama
gabrieldagama previously approved these changes Jun 30, 2020
View reviewed changes
@Nazar65
Copy link
Member Author

Nazar65 commented Jul 1, 2020

@magento run all tests with insfrastructure branch

@Nazar65
Copy link
Member Author

Nazar65 commented Jul 3, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Jul 3, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Jul 3, 2020

@chalov-anton ,done ✔️ could you please take a look ?

@Nazar65
Copy link
Member Author

Nazar65 commented Jul 3, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Jul 6, 2020

@magento run all tests

1 similar comment
@Nazar65
Copy link
Member Author

Nazar65 commented Jul 6, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Jul 6, 2020

@magento run all tests

1 similar comment
@Nazar65
Copy link
Member Author

Nazar65 commented Jul 6, 2020

@magento run all tests

gabrieldagama
gabrieldagama previously approved these changes Jul 6, 2020
View reviewed changes
@Nazar65
Copy link
Member Author

Nazar65 commented Jul 6, 2020

@magento run all tests

@chalov-anton
Copy link
Contributor

✔️ QA Passed

Test scenario on Cucumber Studio - https://studio.cucumber.io/projects/131313/test-plan/folders/1320712/scenarios/4938623
(Test State - In Progress)

@sivaschenko sivaschenko merged commit c98e4ce into magento:2.0-develop Jul 7, 2020
@ghost
Copy link

ghost commented Jul 7, 2020

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@chalov-anton chalov-anton chalov-anton requested changes

@gabrieldagama gabrieldagama gabrieldagama approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gabrieldagama gabrieldagama

@chalov-anton chalov-anton

Labels

MFTF tests MFTF tests coverage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Category grid page

5 participants

@Nazar65 @sivaschenko @chalov-anton @gabrieldagama @lenaorobei