Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backslash in .gitignore on Windows #166

Closed
flancer64 opened this issue Dec 26, 2014 · 1 comment
Closed

Backslash in .gitignore on Windows #166

flancer64 opened this issue Dec 26, 2014 · 1 comment

Comments

@flancer64
Copy link

When I have deployed project with extra parameters as

  "extra": {
    "magento-root-dir": "mage",
    "magento-deploystrategy": "symlink",
    "auto-append-gitignore": true
  }

on my Windows 7 station, I have read the following entries in the mage/.gitignore file:

...
/app/code\core\Mage\Adminhtml\Block\Catalog\Product\Composite\Configure.php
...

some slashes are forward but some are backward. Git ignores these entries when processing .gitignore, I need to change all "" to "/" to fix ignores.

@davidverholen
Copy link

@AydinHassan I think this could be fixed easily in the GitIgnore class.

@AydinHassan @Flyingmana But we should also try to fix the different slashes. Seems like the glob part is taking the DIRECTORY_SEPARATOR while the modman pard keeps the '/'. This should also be converted to the systems DIRECTORY_SEPARATOR I think.

So we might just replace any separators just before writing them to the deployed or removed Files array

Flyingmana added a commit that referenced this issue Dec 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants