Skip to content
This repository was archived by the owner on Apr 29, 2019. It is now read-only.
This repository was archived by the owner on Apr 29, 2019. It is now read-only.

Cleanup History file #122

Closed
Closed
@dmanners

Description

@dmanners

Preconditions (*)

  1. 2.3-develop
  2. phpstan installed composer require --dev phpstan/phpstan

Steps to reproduce (*)

  1. run ./vendor/bin/phpstan analyse -l 0 app/code/Magento/ImportExport/Model/History.php

Expected result (*)

  1. No errors

Actual result (*)

 1/1 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ -------------------------------------------------------------------------------
  Line   History.php
 ------ -------------------------------------------------------------------------------
  66     Access to an undefined property Magento\ImportExport\Model\History::$session.
  313    Access to an undefined property Magento\ImportExport\Model\History::$session.
  314    Access to an undefined property Magento\ImportExport\Model\History::$session.
 ------ -------------------------------------------------------------------------------


 [ERROR] Found 3 errors

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions