Added border to messages for a bit more contrast #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also greatly improves the support for vision deficiencies and high contrast mode
|
Could this possibly be applied only when forced-colors is active? Don't take my opinion as a binding decision: Personally I don't like the appearance with the border. But maybe we could have it both ways by supporting a high contrast mode. |
|
Since we are adding this for visual A11Y reasons and not just for high contrast I would advise against that @rhoerr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also greatly improves the support for vision deficiencies and high contrast mode.
Closes #10