Skip to content

feat: NX based Unit Testing #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2023
Merged

feat: NX based Unit Testing #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/workflows/unit-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
name: Unit Tests
run-name: ${{ github.actor }} is running Unit Tests
on:
pull_request:
branches:
- 2.4-develop

permissions:
contents: write

jobs:
run-unit-tests:
uses: mage-os/infrastructure/.github/workflows/unit-tests.yml@main
8 changes: 8 additions & 0 deletions supported-services.json
View file
Open in desktop
Copy link
Contributor

@sprankhub sprankhub Aug 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am hesitant to add a file to the root directory. Would it be an idea to add it to .github/workflows/ instead?

Copy link
Contributor Author

@adamzero1 adamzero1 Aug 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it got approved in a previous meeting (quite a while ago now).
Ideally I'd like it to go in root, just so it can be part of a release. This way there would be a way to programatically determine what services a specific version of mage-os supports / has been tested.
I was also intending to leverage this file with the integration tests.
What do you think?

Copy link
Contributor

@sprankhub sprankhub Aug 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, why not. No hard feelings here :)

Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"services": {
"php": [
8.1,
8.2
]
}
}