Skip to content

Conversation

@ihor-sviziev
Copy link
Contributor

@ihor-sviziev ihor-sviziev commented Jan 25, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Fixes: Failed the TestModuleOverrideConfig module integration tests.

Magento uses a custom Suite loader, Magento Integration Tests. This custom suite loader isn't getting automatically executed, so in Magento was created a special file that manages custom tests skipping mechanism:
https://github.com/magento/magento2/blob/01f8d7ff759ca1f864b06daae16f5ae54aa3d001/dev/tests/integration/testsuite/Magento/IntegrationTest.php#L39-L59

This is sub-task of mage-os/mageos-magento2#61

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@vpodorozh
Copy link
Contributor

vpodorozh commented Jan 25, 2024

Hello @Vinai - can we merge this one? It's going to fix override.xml failed integration tests and would actually make it closer to the way how integration tests are executed by Magento.

Thank you.

test run: https://github.com/vpodorozh/mageos-magento2/actions/runs/7655377705

Copy link
Contributor

@Vinai Vinai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good 👍

@Vinai Vinai merged commit 120b61c into mage-os:main Jan 25, 2024
@ihor-sviziev ihor-sviziev deleted the patch-1 branch January 25, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants