-
Couldn't load subscription status.
- Fork 30
feat: add pdb support #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces support for Kubernetes PodDisruptionBudget (PDB) in the Helm chart configuration for both the webServer and scheduler components.
- Adds new configuration entries in values.yaml for PDB options.
- Introduces two new template files (pdb.yaml and pdb-scheduler.yaml) to generate PDB resources based on the new configuration.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| charts/mageai/values.yaml | Adds PDB configuration options for webServer and scheduler |
| charts/mageai/templates/pdb.yaml | New template to create a PDB for the webServer component based on values.yaml |
| charts/mageai/templates/pdb-scheduler.yaml | New template to create a PDB for the scheduler component based on values.yaml |
Comments suppressed due to low confidence (1)
charts/mageai/templates/pdb.yaml:10
- [nitpick] Consider using nindent for the minAvailable and maxUnavailable keys to ensure consistent and proper YAML indentation in the generated manifest.
{{- if .Values.webServer.PodDisruptionBudget.minAvailable }}
|
Did you test your change? |
Signed-off-by: fe80 <steffyfort@gmail.com>
|
I had missed the |
Summary
This feature add the support of PodDisruptionBudget
Tests
cc: