Fixed whitespace error causing failures in DFSL_parser & Added ability to import custom PyTorch models #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous version of DFSL_parser did not consider mapping files containing extra whitespace characters \n and \r, added by some IDEs/OSes. This caused a failing error where the parser would fail to match tokens to anything in the list of string constants. Fixed by adding \n and \r to the list of separation characters. Also added some more descriptive debug printouts to the ParseError calls.
OwenHoffend
changed the title
|
Added the ability to import custom PyTorch Models into the frameworks_to_modelfile.py script. This behaves in a similar manner to the custom Keras model import functionality which already existed. |
|
@OwenHoffend Thank you. That's helpful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous version of DFSL_parser did not consider mapping files containing extra whitespace characters \n and \r, added by some IDEs/OSes. This caused a failing error where the parser would fail to match tokens to anything in the list of string constants. Fixed by adding \n and \r to the list of separation characters. Also added some more descriptive debug printouts to the ParseError calls.