Skip to content

Refactor/api folder structure #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

HinsonSIDAN
Copy link
Contributor

@HinsonSIDAN HinsonSIDAN commented Oct 6, 2023

Summary

There is no logic code change in this PR. All changes in application code only due to eslint and prettier rules as configured. This PR refactors the code base to be more collab-friendly, adding

  1. Eslint and prettier coding basis (Issue Extract types into its own file #9)
  2. Commitlint (Issue Extract types into its own file #9)
  3. Splitting api into a readable folder structure (Issue Add code style checking and formatting #16)

Type of Change

Please mark the relevant option(s) for your pull request:

  • [ X ] Code refactoring (improving code quality without changing its behavior)

Additional Information

I just pasted the usual linting I used for other projects. Please feel free to adjust to the one more "Maestro-standard". There are some linting erroor as I plug it in, and currently i disabled them for passing the linting check at commit. See if you guys want to turn it back on:

.eslintrc

    "rules": {
        "class-methods-use-this": "off",
        "prefer-regex-literals": "warn",
        "no-control-regex": "warn",
        "no-use-before-define": "warn",
        "no-param-reassign": "warn",
        "max-classes-per-file": "warn",
        "no-useless-constructor": "off"
    }

@HinsonSIDAN HinsonSIDAN requested a review from a team as a code owner October 6, 2023 07:00
Copy link
Contributor

@Vardominator Vardominator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the massive contribution!

@Vardominator Vardominator merged commit f61633c into maestro-org:main Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants