Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate init sctipt to openrc, fix restarting problem #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

IMbackK
Copy link
Collaborator

@IMbackK IMbackK commented Nov 12, 2020

Migrate init sctipt to openrc, fixes restarting problem
Dsme lifegaurd still works fine becaue the power-dsme module has a harbeat function that it registers with dsme

@parazyd
Copy link
Member

parazyd commented Nov 13, 2020

LGTM. @MerlijnWajer , @freemangordon ?

@MerlijnWajer
Copy link
Member

As discussed on IRC, NACK.

Let's dig into the dsmetool problem, and migrate away from DSME only when we have a functional system. It does a lot and I don't think we can just easily migrate half of our (core) packages.

@MerlijnWajer
Copy link
Member

23:08 < Wizzup> btw, I looked at dsmeutil and dsme/lifeguard.c and it looks like dsme just returns once it has sent kill()
23:08 < Wizzup> and then dsmetool also returns
23:09 < Wizzup> probably mce takes a bit too long to stop and dsmetool already returns and that's why the 'service mce restart' fails
23:09 < uvos> possibly
23:09 < Wizzup> pretty sure
23:09 < Wizzup> by default it sends SIGTERM
23:09 < uvos> ok
23:10 < uvos> yeah mce takes some time to quit
23:10 < uvos> orderly
23:10 < Wizzup> right
23:10 < uvos> mce is slow as hell in general
23:10 < uvos> i have a branch with some threads
23:10 < Wizzup> but we don't want dsme to block waiting for the process to die
23:11 < Wizzup> I mean we want dsme to take care of it proper I guess, but we also don't really want it to do that since it's not an init proc for us

@freemangordon
Copy link
Contributor

Is this still a thing?

@IMbackK
Copy link
Collaborator Author

IMbackK commented Jan 10, 2024

i use mce on plain debian and used to merge this in since the stock script creates a unnecessary hard dependency on dsme.
I still think dsme is just bad, and we should use systemd instead (since it provides all relevant functionality implemented much better) or use supervise-deamon at minimally reduced functionality.

Anyhow this pr is useful for anyone wanting to run mce outside maemo, so it should stick around or be made into a branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants