This repository was archived by the owner on Dec 21, 2024. It is now read-only.
Add timezone to timestamp #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, when a JsonFormatter is created with the timestamp= True parameter, it used utcnow(). Which is not time when the log record was created, but when the field was added. Also, utcnow is not timezone aware, so the serialized datetime is missing the timezone designator at the end. This commit uses the time at which the log record was created and sets the timezone to UTC, which results in an additional "+000" end
Owner
|
Thanks for this and sorry for the HUGE delay! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "timestamp" field does not contain timezone information. If you don't live in GMT, that is probably wrong for you. This PR adds an additional "+000" to the serialized datetime.
Also, it uses the log creation timestamp, not whatever time it is when the field gets added.