This repository was archived by the owner on Dec 21, 2024. It is now read-only.
#147: Feature request: Add ECS compatibility #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madzak
suggested changes
Nov 29, 2022
src/pythonjsonlogger/jsonlogger.py
Outdated
|
|
||
|
|
||
| def merge_record_extra(record: logging.LogRecord, target: Dict, reserved: Union[Dict, List]) -> Dict: | ||
| JSONLOGGER_RENAME_FIELDS_ECS: Dict[str, str] = { |
There was a problem hiding this comment.
I don't want to include cloud specific maps (discussed in the corresponding message #147 ), please remove this.
There was a problem hiding this comment.
I will remove it, but there is no restriction to any cloud context.
I recommend to have a look here: https://www.elastic.co/guide/en/ecs/current/ecs-reference.html
|
@madzak please take a look at my PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.