Skip to content

Make this package browser friendly  #132

@barak007

Description

@barak007

Hello we have a use case that we want to use this plugin in the browser and bundle it via webpack.
Currently the FileSystemLoader is being use as a fallback loader if no load provided via the config, and it is always imported by the package index.

The issue is:
FileSystemLoader imports nodejs fs module and that's not browser friendly (needs config in order to bundle).

I have few suggestions for solutions to this issue:

  1. Add "browser" field to the package.json that will implement a "loader" that throws something like "when using this package in browser you must provide a custom loader"
  2. Create entrypoint specifically for browser usage which does not import FileSystemLoader by default
  3. Allow inject the fs module to the loaders avoiding importing it directly (split the index into a factory that will accept fs)

These are non-breaking changes that can be done here.

We are willing to make this PR.

Please advice.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions