Refactor browser and metal examples to use OnceCell #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanshade
force-pushed
the
example-refactoring-once-cell
branch
3 times, most recently
from
7761d9b
to
1759f43
Compare
madsmtm
added
documentation
madsmtm
approved these changes
Sep 3, 2023
silvanshade
force-pushed
the
example-refactoring-once-cell
branch
from
1759f43
to
02a6ab4
Compare
silvanshade
force-pushed
the
example-refactoring-once-cell
branch
from
02a6ab4
to
f9db7ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
browserandmetalexamples to useOnceCellinstead ofRefCell.I feel this is a more precise representation of how those ivars are used since they are intended to only be initialized once, and it should be an error to try and set them again (in this case, although in other scenarios
RefCellcould certainly make sense).As a nice side effect, it should be a little more efficient and we don't seem to need the inner
Optioneither.