New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix browser example #484

Merged

madsmtm merged 1 commit into madsmtm:master from silvanshade:fix-browser-example

Aug 25, 2023

Contributor

silvanshade commented Aug 22, 2023

It doesn't look like the browser example is currently being tested in CI either but I wasn't sure how to (re-)enable that.


          Fix browser example

60e90b6

Owner

madsmtm commented Aug 25, 2023 •

edited

Loading

Yeah it's not tested in CI currently, I think that's because of:

objc2/.github/workflows/ci.yml

Lines 98 to 103 in 3d9b686

    
                     # Ideally this would use $LATEST_MACOS_FEATURE, but this causes clippy to 
        
                     # use too much memory for the CI runner 
        
                     args: >- 
        
                       $PUBLIC_CRATES 
        
                       --features=$INTERESTING_FEATURES 
        
                       --features=unstable-frameworks-macos-12

Fix looks good though, thanks!

madsmtm merged commit add2edd into madsmtm:master

18 of 19 checks passed

madsmtm added bug A-framework labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-framework bug