Appease clippy

.github/workflows/ci.yml

@@ -150,7 +150,8 @@ jobs:
       run: cargo doc --no-deps --document-private-items ${{ matrix.args }}
 
     - name: cargo clippy
-      run: cargo clippy --all-targets ${{ matrix.args }}
+      # Temporarily allow diverging_sub_expression until we figure out how to silence them in declare_class!
+      run: cargo clippy --all-targets ${{ matrix.args }} -- --allow=clippy::diverging_sub_expression
 
   msrv:
     name: Check MSRV

crates/icrate/src/Foundation/additions/string.rs

@@ -192,7 +192,7 @@ impl Ord for NSString {
 impl PartialOrd for NSMutableString {
     #[inline]
     fn partial_cmp(&self, other: &Self) -> Option<cmp::Ordering> {
-        PartialOrd::partial_cmp(&**self, &**other)
+        Some(self.cmp(other))
     }
 }
 

crates/icrate/tests/exception.rs

@@ -46,7 +46,7 @@ fn unwrap() {
     )
     .unwrap();
 
-    let _: () = Err(exc).unwrap();
+    let _: () = panic!("{exc:?}");
 }
 
 // Further tests in `tests::exception`

crates/objc2/src/rc/id.rs

@@ -231,6 +231,8 @@ impl<T: ?Sized + Message> Id<T> {
     /// This is an associated method, and must be called as
     /// `Id::as_mut_ptr(obj)`.
     #[inline]
+    #[allow(unknown_lints)] // New lint below
+    #[allow(clippy::needless_pass_by_ref_mut)]
     pub fn as_mut_ptr(this: &mut Self) -> *mut T
     where
         T: IsMutable,