Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned and updated #133

Merged
merged 2 commits into from
Feb 25, 2020
Merged

Cleaned and updated #133

merged 2 commits into from
Feb 25, 2020

Conversation

wforney
Copy link
Contributor

@wforney wforney commented Feb 25, 2020

  • Cleaned up formatting, added editorconfig
  • Commented all cs files using GhostDoc and hand editing
  • Used is for == in some places
  • Used LINQ and new IAsyncEnumerable in places

@madskristensen
Copy link
Owner

Thanks for the PR. All the comments you've added aren't adding any positive value, since they just state something like Gets or sets the slug.

@wforney
Copy link
Contributor Author

wforney commented Feb 25, 2020

Yeah, I get that. They are mostly auto-generated with GhostDoc. I used to use Sandcastle to make docs based on those. I'm on the fence about whether to ditch the auto-gen docs in my other projects too.

@wforney wforney changed the title Cleaned, commented and updated Cleaned and updated Feb 25, 2020
@madskristensen madskristensen merged commit 82ab3bd into madskristensen:master Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants