chore: bump rdkafka to v0.37.0 #239
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Because we have made a lot modifications to the upstream version, directly copying the upstream code might lead to problems. Previously, my method to upgrade the rdkafka version was as follows:
- Get the diff between
madsim-rdkafka/src/stdand the corresponding community version. - Completely reset
madsim-rdkafka/src/stdto the new community version. - Apply the diff and resolve any conflicts.
Comment on lines
-337
to
390
| #[async_trait::async_trait] | ||
| impl FromClientConfig for AdminClient<DefaultClientContext> { | ||
| async fn from_config(config: &ClientConfig) -> KafkaResult<AdminClient<DefaultClientContext>> { | ||
| AdminClient::from_config_and_context(config, DefaultClientContext).await | ||
| fn from_config(config: &ClientConfig) -> KafkaResult<AdminClient<DefaultClientContext>> { | ||
| AdminClient::from_config_and_context(config, DefaultClientContext) | ||
| } | ||
| } |
There was a problem hiding this comment.
We should keep these functions async for simulation?
https://github.com/madsim-rs/madsim/tree/main/madsim-rdkafka#api-modification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.