Improve compatibility between boards with different processors #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This very simple edit changes "int" to "int16_t" for all the examples.
Several users have reported problems using EasyTransfer between AVR-based boards like Arduino Nano and 32 bit boards like Teensy or Arduino Zero. EasyTransfer works great when the structs are perfectly identical. But since int is 16 bits on AVR and 32 bits on most other boards, the examples fail when people try to use them to communicate between different boards.
This pull request also changes 2 of the examples to use INPUT_PULLUP. While Teensy and many other boards do emulate the AVR-specific behavior of digitalWrite() to control pullups, some newer boards do not support this. INPUT_PULLUP is well supported on all boards with all modern versions of Arduino.