Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds detect support for mobile Chrome browser #596

Merged
merged 1 commit into from
Sep 25, 2012

Conversation

elgerlambert
Copy link
Contributor

Adds browser sniffing for chrome on both Android and iOS (different ua strings - https://developers.google.com/chrome/mobile/docs/user-agent)

Adds browser sniffing for chrome on both Android and iOS (different ua strings - https://developers.google.com/chrome/mobile/docs/user-agent)
@elgerlambert
Copy link
Contributor Author

Had the need to distinguish between Android's default browser and Chrome. Noticed that Chrome uses a different User Agent string on iOS so I included that aswell.

Tests are included using example User Agent Strings taken from https://developers.google.com/chrome/mobile/docs/user-agent. I also tested it on a Samsung Galaxy S II running Android 4.0.3 and an iPhone 4 running iOS 5.1.1.

Note: $.browser.version will return Chrome's version number; overwriting webkit's version nummer (similar to the current implementation of detect silk)

madrobby added a commit that referenced this pull request Sep 25, 2012
Adds detect support for mobile Chrome browser
@madrobby madrobby merged commit e92dc43 into madrobby:master Sep 25, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants