Export global.key explicitly (makes keymaster work w/ chrome apps & browserify)
#110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Ping. Let's merge this! |
|
+1 |
Author
|
Yo @madrobby - this is trivial, please merge. |
Author
|
Hey @madrobby, just ran into this bug again. This time with chrome apps. Please merge this fix! |
|
+1, I need this |
|
+1 |
|
@madrobby this is definitely required for browserify. |
Author
|
@madrobby - Why don't you merge this? You use |
Author
|
Nevermind, I see this was fixed in 0f09fc1. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial change, makes the library work when
thisis not actuallywindoworglobal. This happens with the popular build tool browserify.