Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not test WIN32, instead test _WIN32 #978

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Do not test WIN32, instead test _WIN32 #978

wants to merge 1 commit into from

Commits on Jun 8, 2024

  1. Do not test WIN32, instead test _WIN32 

    To the best of my knowledge:
* `_WIN32` and `_WIN64` are defined by the compiler,
* `WIN32` and `WIN64` are defined by the user, to indicate whatever
  the user chooses them to indicate. They mean 32-bit and 64-bit Windows
  compilation by convention only.

See:
https://accu.org/journals/overload/24/132/wilson_2223/

Windows compilers in general, and MSVC in particular, have been defining
`_WIN32` and `_WIN64` for a long time, provably at least since Visual Studio
2015, and in practice as early as in the days of 16-bit Windows.

See:
https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-140
https://learn.microsoft.com/en-us/windows/win32/winprog64/the-tools

Tests used to be inconsistent, usually testing `_WIN32` and here testing `WIN32`.
This brings consistency to Windows detection.
    @DimitriPapadopoulos
    DimitriPapadopoulos committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    3134c70 View commit details
    Browse the repository at this point in the history