-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix typos #673
fix typos #673
Conversation
Adler/Gailly contrib/dotzlib/DotZLib/GZipStream.cs concluded writeable was not a typo if the ChangeLog and/or contrib/minizip/MiniZip64_Changes.txt are to be modified uncomment the relevant lines
|
@fluesvamp: Your PR has been closed, it has not been merged. |
I have incorporated most of these anyway. (Just not the ones in contrib that aren't mine.) |
@madler: I do not see merging of a part of this... Note that contribs are not from you but it is important to update it... Can you use GitHub to merge it? |
I haven't pushed it yet. |
I don't quite understanding what you're saying. Anyway, in general, I will leave it to the contributors to to update their own contributions. |
@madler: The problem is if contributors are not active, there are a lot badly. I can create a PR with contrib typo fixes from @fluesvamp but you will not merge it because I am not the original author of the contrib. Normally master branch is up-to-date, and the important is the tag with build version and it will be better to develop... You can look other projects, for example PPP: https://github.com/ppp-project/ppp You can compare with zlib: It is time to look all current PRs? |
Adler/Gailly contrib/README.contrib - All files under this contrib directory are UNSUPPORTED. There were
+ All files under this contrib directory are UNSUPPORTED. They were |
Thanks. Fixed. |
No description provided.