Fix compilation warnings #388
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this, there were two places in contrib/minizip that used an `#ifdef` with an `||` operator. This resulted in a warning of unrecognized (and ignored) tokens after the `#ifdef`. While this worked for all `unix` variants, it would not use that branch for `__APPLE`. That is bad because a) it won't work on `__APPLE__` and b) there are warnings from the compilation. The solution is to use `#if defined(x) || defined(y)` since the `if` supports using an `||` operator.
Before this, a warning for line 495 in minizip.c would be issued since the variable `fin` may not be initialized. This fixes the warning by assigning `NULL` to `fin` where it is introduced.
Before this, there would be a warning of 'implicit declaration of mkdir' for the miniunz.c file on line 131 where it calls `mkdir`. That is bad because there is a warning. The fix is to include the appropriate header files as indicated by `man(2) mkdir`; `sys/stat.h` and `sys/types.h`. This fix is for unix flavoured systems, but may need to be tweaked for some flavours.
Before this, there would be a warning for the lines 521 and 529 in contrib/minizip/zip.c. This was caused by the `for` loop on line 521 not having braces around the body of the `for`, and that the subsequent statement on line 529 was indented to look like it was part of the `for` body. This is now corrected by fixing the bad indentation. The alternative of placing braces around the `for` body was considered but that style is not typically used in the zlib codebase.
|
Please note that there is https://github.com/nmoinvaz/minizip. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple of compilation warnings in contrib/minizip. See the respective commit message for each fix.