fixed for out-of-source build #344
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -230,6 +230,7 @@ endif() | |||
| # Example binaries | |||
| #============================================================================ | |||
|
|
|||
| if(NOT SKIP_EXAMPLES) | |||
There was a problem hiding this comment.
should this be SKIP_ZLIB_EXAMPLES, perhaps?
There was a problem hiding this comment.
Fixing the include above to be:
include_directories(${CMAKE_CURRENT_BINARY_DIR} ${CMAKE_CURRENT_SOURCE_DIR})
results in the examples compiling, so perhaps you don't need to exclude them.
There was a problem hiding this comment.
Fixing the include directories seems better, indeed :D
malytomas
commented
Jul 11, 2018
| @@ -74,7 +74,7 @@ if(NOT CMAKE_CURRENT_SOURCE_DIR STREQUAL CMAKE_CURRENT_BINARY_DIR) | |||
| message(STATUS " ${CMAKE_CURRENT_SOURCE_DIR}/zconf.h") | |||
| message(STATUS "to 'zconf.h.included' because this file is included with zlib") | |||
| message(STATUS "but CMake generates it automatically in the build directory.") | |||
| file(RENAME ${CMAKE_CURRENT_SOURCE_DIR}/zconf.h ${CMAKE_CURRENT_SOURCE_DIR}/zconf.h.included) | |||
| configure_file(${CMAKE_CURRENT_SOURCE_DIR}/zconf.h ${CMAKE_CURRENT_BINARY_DIR}/zconf.h.included COPYONLY) | |||
There was a problem hiding this comment.
Issue #133 might be related to this.
Tbh, I remember this had something to do with CMAKE_DISABLE_SOURCE_CHANGES, but it seems to work now.
|
Is there a reason that the pull request isn't accepted until now? |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.