ci: remove deprecated node versions

madlabsinc · Sep 20, 2023 · d439de3 · d439de3
1 parent ad04af6
commit d439de3
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 9 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -12,7 +12,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, macos-latest, windows-latest]
-        node: [12, 14]
+        node: [16, 18, 20]
     steps:
       - uses: actions/checkout@v2
       - name: Setup node

diff --git a/__e2e__/commands/init.test.js b/__e2e__/commands/init.test.js
@@ -97,7 +97,7 @@ describe('mevn init', () => {
   });
 
   it('creates a new MEVN stack webapp based on the GraphQL starter template', async () => {
-    const { exitCode } = await runPromptWithAnswers(
+    const { exitCode, stderr } = await runPromptWithAnswers(
       ['init', 'my-app'],
       [
         `${DOWN}${DOWN}${ENTER}`, // Choose GraphQL as the starter template
@@ -107,6 +107,8 @@ describe('mevn init', () => {
       tempDirPath,
     );
 
+    console.error(stderr);
+
     expect(exitCode).toBe(0);
     expect(fetchProjectConfig(genPath).template).toBe('GraphQL');
     expect(fetchProjectConfig(genPath).isConfigured.client).toBe(false);
@@ -124,7 +126,7 @@ describe('mevn init', () => {
   });
 
   it('creates a new MEVN stack webapp based on the PWA starter template', async () => {
-    const { exitCode } = await runPromptWithAnswers(
+    const { exitCode, stderr } = await runPromptWithAnswers(
       ['init', 'my-app'],
       [
         `${DOWN}${ENTER}`, // Choose PWA as the starter template
@@ -134,6 +136,8 @@ describe('mevn init', () => {
       tempDirPath,
     );
 
+    console.error(stderr);
+
     expect(exitCode).toBe(0);
     expect(fetchProjectConfig(genPath).template).toBe('PWA');
     expect(fetchProjectConfig(genPath).isConfigured.client).toBe(false);
@@ -160,10 +164,9 @@ describe('mevn init', () => {
   });
 
   it('creates a new MEVN stack webapp based on the Default starter template in current directory', async () => {
-    // Create my-app directory
     fs.mkdirSync(genPath);
 
-    const { exitCode } = await runPromptWithAnswers(
+    const { exitCode, stderr } = await runPromptWithAnswers(
       ['init', '.'],
       [
         ENTER, // Choose Default as the starter template
@@ -173,6 +176,8 @@ describe('mevn init', () => {
       genPath,
     );
 
+    console.error(stderr);
+
     expect(exitCode).toBe(0);
     expect(fetchProjectConfig(genPath).template).toBe('Default');
     expect(fetchProjectConfig(genPath).isConfigured.client).toBe(false);

diff --git a/jest/helpers.js b/jest/helpers.js
@@ -25,6 +25,6 @@ export const runPromptWithAnswers = (args, answers, testPath) => {
 // Cleanup
 export const rmTempDir = (tempDirPath) => {
   if (fs.existsSync(tempDirPath)) {
-    fs.rmdirSync(tempDirPath, { recursive: true });
+    fs.rmSync(tempDirPath, { recursive: true });
   }
 };
diff --git a/src/utils/__tests__/helpers.test.js b/src/utils/__tests__/helpers.test.js
@@ -23,11 +23,11 @@ beforeAll(() => {
 
 afterAll(() => {
   // copyDirSync()
-  fs.rmdirSync(srcPath, { recursive: true });
-  fs.rmdirSync(destPath, { recursive: true });
+  fs.rm(srcPath, { recursive: true });
+  fs.rm(destPath, { recursive: true });
 
   // fetchProjectConfig()
-  fs.rmdirSync(genPath, { recursive: true });
+  fs.rm(genPath, { recursive: true });
 });
 
 test('copyDirSync()', () => {