Update MG5AMC with valgrind fixes (and regenerate all processes)#869
Merged
valassi merged 16 commits intomadgraph5:masterfrom Jun 27, 2024
Merged
Update MG5AMC with valgrind fixes (and regenerate all processes)#869valassi merged 16 commits intomadgraph5:masterfrom
valassi merged 16 commits intomadgraph5:masterfrom
Conversation
… logs from gdb and valgrind (will then revert)
…n build options (it does nothing useful, will revert)
…o Fortran build options (it does nothing useful, will revert)" This reverts commit 6d07d4c.
…r better logs from gdb and valgrind (will then revert)" This reverts commit 3a7a3e8.
…grind leak warning madgraph5#868 ==3682257== 544 (32 direct, 512 indirect) bytes in 1 blocks are definitely lost in loss record 3 of 3 ==3682257== at 0x719786F: malloc (vg_replace_malloc.c:381) ==3682257== by 0x7404CC8: ??? (in /usr/lib64/libgfortran.so.5.0.0) ==3682257== by 0x7647C63: ??? (in /usr/lib64/libgfortran.so.5.0.0) ==3682257== by 0x7635319: ??? (in /usr/lib64/libgfortran.so.5.0.0) ==3682257== by 0x76357FC: _gfortran_st_open (in /usr/lib64/libgfortran.so.5.0.0) ==3682257== by 0x47AA9F: open_file_ (open_file.f:40) ==3682257== by 0x432C91: MAIN__ (driver.f:151) ==3682257== by 0x40268E: main (driver.f:301) ==3682257==
…clscales (workaround for valgrind undefined behaviour madgraph5#868) ==3687827== Conditional jump or move depends on uninitialised value(s) ==3687827== at 0x425E73: setclscales_ (reweight.f:1230) ==3687827== by 0x4284D9: update_scale_coupling_vec_ (reweight.f:1876) ==3687827== by 0x436BC7: dsig_vec_ (auto_dsig.f:316) ==3687827== by 0x45AFEA: sample_full_ (dsample.f:208) ==3687827== by 0x4331AD: MAIN__ (driver.f:257) ==3687827== by 0x40268E: main (driver.f:302) ==3687827== Uninitialised value was created by a stack allocation ==3687827== at 0x424051: setclscales_ (reweight.f:555)
…ments in reweight.f)
…d PR madgraph5#112 into the gpucpp branch
…proximations ./CODEGEN/generateAndCompare.sh gg_tt --mad --nopatch git diff --no-ext-diff -R gg_tt.mad/Source/makefile gg_tt.mad/Source/dsample.f gg_tt.mad/Source/genps.inc gg_tt.mad/SubProcesses/makefile > CODEGEN/PLUGIN/CUDACPP_SA_OUTPUT/MG5aMC_patches/PROD/patch.common git diff --no-ext-diff -R gg_tt.mad/bin/internal/banner.py gg_tt.mad/bin/internal/gen_ximprove.py gg_tt.mad/bin/internal/madevent_interface.py >> CODEGEN/PLUGIN/CUDACPP_SA_OUTPUT/MG5aMC_patches/PROD/patch.common git diff --no-ext-diff -R gg_tt.mad/SubProcesses/P1_gg_ttx/auto_dsig1.f gg_tt.mad/SubProcesses/P1_gg_ttx/driver.f gg_tt.mad/SubProcesses/P1_gg_ttx/matrix1.f > CODEGEN/PLUGIN/CUDACPP_SA_OUTPUT/MG5aMC_patches/PROD/patch.P1 git checkout gg_tt.mad
…eam/master to ease merges git checkout upstream/master $(git ls-tree --name-only HEAD */CODEGEN*txt)
Member
|
Thanks Andrea, let's merge this. |
Member
Author
Thanks a lot Olivier. Merging this one too. |
valassi
added a commit
to valassi/madgraph4gpu
that referenced
this pull request
Jun 27, 2024
…and valgrind fixes madgraph5#869) into tmad
valassi
added a commit
to valassi/madgraph4gpu
that referenced
this pull request
Jun 27, 2024
…adgraph5#794 and valgrind fixes madgraph5#869): no change in the code
Closed
Closed
valassi
added a commit
to valassi/madgraph4gpu
that referenced
this pull request
Jun 27, 2024
…and valgrind fixes madgraph5#869) into susy Fix conflicts in MG5aMC/mg5amcnlo (keep the latest gpucpp_826 version including the recent gpucpp changes)
valassi
added a commit
to valassi/madgraph4gpu
that referenced
this pull request
Jun 27, 2024
…and valgrind fixes madgraph5#869) into susy Fix conflicts in MG5aMC/mg5amcnlo (keep the latest gpucpp_826 version including the recent gpucpp changes)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update MG5AMC with valgrind fixes (and regenerate all processes)
Addresses the issues described in #868
Includes MG5AMC upgrades for
mg5amcnlo/mg5amcnlo#110
mg5amcnlo/mg5amcnlo#112
@oliviermattelaer can you please review? Should be non controversial...
Thanks
Andrea