Skip to content

added CommonRandomNumbers.h to code generation#657

Merged
zeniheisser merged 1 commit intomadgraph5:masterfrom
zeniheisser:procGen
May 23, 2023
Merged

added CommonRandomNumbers.h to code generation#657
zeniheisser merged 1 commit intomadgraph5:masterfrom
zeniheisser:procGen

Conversation

@zeniheisser
Copy link
Contributor

Minor fix to the plugin, so that all necessary headers are exported at code generation

only missing part to be able to run straight out of the madgraph interface now is googletests

@roiser
Copy link
Member

roiser commented May 23, 2023

Shall we remove the header in the "old" place in our github repo (/tools)?

@zeniheisser
Copy link
Contributor Author

@roiser that would probably make sense, no reason to keep double copies of it

@zeniheisser zeniheisser merged commit b1f4d2a into madgraph5:master May 23, 2023
@valassi
Copy link
Member

valassi commented May 23, 2023

Hi @zeniheisser thanks for the patch!

There were (to my taste) a few missing issues, I have now included them in a followup MR #662, in particular

  • I regenerated all processes SA and MAD in the repo with the patch in epochX/cudacpp
  • I removed the dependency on the tools directory from cudacpp.mk (this is one of the main points of removing CommonRandomNumbers.h: the dependency is no longer needed, then it is better to remove it for clarity, also so that there is no confusion where the headers are taken from)
  • As CommonRandomNumbers.h is now in the plugin, my script checked formatting, and so I reformatted it using clang-format (in addition, I also added the license and copyright)

@valassi
Copy link
Member

valassi commented May 23, 2023

PS This is related to #613 (generated code should be relocatable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

generated code must be relocatable (must build outside the madgraph4gpu project)

3 participants