Remove helicity filtering from cudacpp ME timers in (c/g)madevent#463
Merged
valassi merged 6 commits intomadgraph5:masterfrom May 22, 2022
Merged
Remove helicity filtering from cudacpp ME timers in (c/g)madevent#463valassi merged 6 commits intomadgraph5:masterfrom
valassi merged 6 commits intomadgraph5:masterfrom
Conversation
…ow closer after removing helicity filtering
…esses after removing helicity filtering (madgraph5#461) - much better Difference between cudacpp ME performance in madevent and in SA/bridge is within 10% for complex processes. For eemumu and ggtt the difference is still quite large instead. This is now understood: madevent throughput is lower because it includes data copies/transposing (in the SA "bridge" mode the timers really only compute the ME calculation)
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR addressing #461 - I observed a difference in cudacpp ME throughputs when computed in standalone mode (even in bridge mode) and within cmadevent/gmadevent.
The largest part of the difference (a factor 2, because I only do one iteration in these tests) is due to the fact that I was not removing helicity filtering in the cudacpp timers. So Fortran MEs includes only one ME calculation, while cudacpp includes two (the first one for helicity filtering, the second one for real ME calculation).
This is now fixed in this PR.