Move CUDA builds from C++14 to C++17#354
Merged
valassi merged 24 commits intomadgraph5:masterfrom Jan 26, 2022
Merged
Conversation
…ot built with OpenMP for a long time) (Originally from the nvccsimd branch in Dec 2021)
… that OpenMP required this (madgraph5#269)
… for compilation) (Originally from the nvccsimd branch in Dec 2021)
(Originally from the nvccsimd branch in Dec 2021)
… to detect if nvcc was used (Originally from the nvccsimd branch in Dec 2021)
…JOR_VERSION__ to detect if nvcc was used as compiler
These had been overridden by mistakes in 1e7fd92
(ggttggg takes too long to build, cannot be used routinely...)
Member
Author
|
This is now ready to be merged, it includes
|
Member
Author
|
I have added a (TEMPORARY?) patch to allow gcc<9.3 when it is used as toolchain for clang, else the CI was failing (#355) |
This was referenced Jan 26, 2022
Member
Author
|
All checks pass, I am self merging |
This was referenced Jan 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the PR to fix #333.
Still WIP for now but will complete and merge soon