Skip to content

Allow cucomplex and thrust only for CUDA but not for HIP? #810

@valassi

Description

@valassi

Best complex type for HIP? (allow cucomplex and thrust only for CUDA but not for HIP?)

In PR #801 I noticed that the mgOnGpuCxtypes.h was modifed to allow cucomplex and thrust not only for CUDA but also for HIP. Maybe this was intentional, maybe not, maybe it is actually a very good idea, maybe not?

There are some weird side effects however, e.g. the printouts in check.cc show "???" as complex type, which means that some parts of the code are in unexpected states (which should be internal errors).

I will disable cucomplex and thrust for HIP for the moment. In any case we are far from doing HIP otimizations... we can come back to this later on.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions