Change the naming convention for SIMD defines and modes

[valassi]

This is a followup to #221 and PR #421.

The SIMD modes we are supporting were initially designed for Intel, and are using an Intel naming convention, both in their short tag description and especially in their ifdefs in the code. Non-Intel platforms are supported using the ugly hack of adding Intel like defines in the code instead of using native ones (namely, Power9 VSX and ARM Neon, both 128 bits, are supported by artificially adding an SSE42 define).

This should be improved in one or maybe two ways:

• first, the ifdefs in the code should certainly be changed (this must be done)
• second, optionally, the short text descriptions could be changed (this I am not yet convinced about, we have many tables using the old nomenclature... to be decided)

About the first point, the part that needs to be changed is especially this one

madgraph4gpu/epochX/cudacpp/gg_tt/src/mgOnGpuConfig.h

Line 125 in e2c4c0a

// C++ SIMD vectorization width (this will be used to set neppV)

// C++ SIMD vectorization width (this will be used to set neppV)
#ifdef __CUDACC__ // CUDA implementation has no SIMD
#undef MGONGPU_CPPSIMD
#elif defined __AVX512VL__ && defined MGONGPU_PVW512 // C++ "512z" AVX512 with 512 width (512-bit ie 64-byte): 8 (DOUBLE) or 16 (FLOAT)
#ifdef MGONGPU_FPTYPE_DOUBLE
#define MGONGPU_CPPSIMD 8
#else
#define MGONGPU_CPPSIMD 16
#endif
#elif defined __AVX512VL__ // C++ "512y" AVX512 with 256 width (256-bit ie 32-byte): 4 (DOUBLE) or 8 (FLOAT) [gcc DEFAULT]
#ifdef MGONGPU_FPTYPE_DOUBLE
#define MGONGPU_CPPSIMD 4
#else
#define MGONGPU_CPPSIMD 8
#endif
#elif defined __AVX2__ // C++ "avx2" AVX2 (256-bit ie 32-byte): 4 (DOUBLE) or 8 (FLOAT) [clang DEFAULT]
#ifdef MGONGPU_FPTYPE_DOUBLE
#define MGONGPU_CPPSIMD 4
#else
#define MGONGPU_CPPSIMD 8
#endif
#elif defined __SSE4_2__ // C++ "sse4" SSE4.2 (128-bit ie 16-byte): 2 (DOUBLE) or 4 (FLOAT) [Power9 and ARM default]
#ifdef MGONGPU_FPTYPE_DOUBLE
#define MGONGPU_CPPSIMD 2
#else
#define MGONGPU_CPPSIMD 4
#endif
#else // C++ "none" i.e. no SIMD
#undef MGONGPU_CPPSIMD
#endif

and correspondingly this one

madgraph4gpu/epochX/cudacpp/gg_tt/SubProcesses/Makefile

Line 221 in e2c4c0a

# Set the build flags appropriate to each AVX choice (example: "make AVX=none")

# Set the build flags appropriate to each AVX choice (example: "make AVX=none")
# [NB MGONGPU_PVW512 is needed because "-mprefer-vector-width=256" is not exposed in a macro]
# [See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96476]
$(info AVX=$(AVX))
ifeq ($(UNAME_P),ppc64le)
  ifeq ($(AVX),sse4)
    override AVXFLAGS = -D__SSE4_2__ # Power9 VSX with 128 width (VSR registers)
  else ifneq ($(AVX),none)
    $(error Unknown AVX='$(AVX)': only 'none' and 'sse4' are supported on PowerPC for the moment)
  endif
else ifeq ($(UNAME_P),arm)
  ifeq ($(AVX),sse4)
    override AVXFLAGS = -D__SSE4_2__ # ARM NEON with 128 width (Q/quadword registers)
  else ifneq ($(AVX),none)
    $(error Unknown AVX='$(AVX)': only 'none' and 'sse4' are supported on ARM for the moment)
  endif
else
  ifeq ($(AVX),sse4)
    override AVXFLAGS = -march=nehalem # SSE4.2 with 128 width (xmm registers)
  else ifeq ($(AVX),avx2)
    override AVXFLAGS = -march=haswell # AVX2 with 256 width (ymm registers) [DEFAULT for clang]
  else ifeq ($(AVX),512y)
    override AVXFLAGS = -march=skylake-avx512 -mprefer-vector-width=256 # AVX512 with 256 width (ymm registers) [DEFAULT for gcc]
  else ifeq ($(AVX),512z)
    override AVXFLAGS = -march=skylake-avx512 -DMGONGPU_PVW512 # AVX512 with 512 width (zmm registers)
  else ifneq ($(AVX),none)
    $(error Unknown AVX='$(AVX)': only 'none', 'sse4', 'avx2', '512y' and '512z' are supported)
  endif
endif
# For the moment, use AVXFLAGS everywhere: eventually, use them only in encapsulated implementations?
CXXFLAGS+= $(AVXFLAGS)

One possibility could be to use defines like

• for 'none', -DMGONGPU_SIMDNONE
• for 'sse4', -DMGONGPU_SIMD128
• for 'avx2' and '512y', -DMGONGPU_SIMD256 (relying on AVX512VL to decide whether this is 'avx2' or '512y')
• for '512z', -DMGONGPU_SIMD512
  Note that 512y is a peculiar case, using 256bit registers but also some AVX512 symbols, and it is clearly an Intel specific thing.

For the tag names, I would be inclined to keep 'none', 'sse42' etc, precisely because things like '512y' are very difficult to describe in terms of register width (otherwise it would be '256plus' or something similar...).

To be discussed. Not too urgent, anyway.

[valassi]

Specifically, note that ARM and Power9 code would no longer go through "#if defined SSE4_2".

The set of ifdefs however would become a bit more complex, because one should check whether the user-required mode is supported at all. For instance

• if one asks -DMGONGPU_SIMD128, one should check on Intel "#if defined SSE4_2" is set, and similarly for ARM if "#if defined ARM_NEON" is set, otherwise a compilation error should be triggered
• if one asks -DMGONGPU_SIMD256, one should check whether avx2 or 512y mode is being used... but this is only for writing out which tag is being used

Note also that one can use 'AVX=sse4' (I would keep this tag, as mentioned(, but the code prints out already now 'sse4', 'ppcv' or 'neon' depending on the architecture,

madgraph4gpu/epochX/cudacpp/gg_tt/SubProcesses/P1_Sigma_sm_gg_ttx/check_sa.cc

Line 753 in e2c4c0a

#if !defined MGONGPU_CPPSIMD

    // -- SIMD matrix elements?
#if !defined MGONGPU_CPPSIMD
  wrkflwtxt += "/none";
#elif defined __AVX512VL__
#ifdef MGONGPU_PVW512
  wrkflwtxt += "/512z";
#else
  wrkflwtxt += "/512y";
#endif
#elif defined __AVX2__
  wrkflwtxt += "/avx2";
#elif defined __SSE4_2__
#ifdef __PPC__
  wrkflwtxt += "/ppcv";
#elif defined __ARM_NEON__
  wrkflwtxt += "/neon";
#else
  wrkflwtxt += "/sse4";
#endif
#else
  wrkflwtxt += "/????"; // no path to this statement
#endif

[valassi]

This is related to #585 where I suggest -march based on thsings like x86-64-v3
https://www.phoronix.com/news/GCC-11-x86-64-Feature-Levels

The SIMD modes however should be more generic, and x86-agnostic if possible (but the register size alone is not enough, as both vx2 and 512y use 256 bit registers...)