Empty string replace fix

[DrDeath72]

When replace with empty string '' it replace it by invalid, but need leave empty string

sourceString = sourceString.replace(new RegExp(key, 'g'), value === '' ? value : value || options.invalid);

or

sourceString = sourceString.replace(new RegExp(key, 'g'), value);

[madflow]

Would you like to open a pull request with a test for this? I'd be happy to merge contributions.

[DrDeath72]

i'm noob on github :)

[madflow]

This would be "the" opportunity to get to know the Github ecosystem ;)

[madflow]

See https://github.com/madflow/jquery-slugify/blob/master/CONTRIBUTING.md

[madflow]

I added a test. Works for me - or I did not get the "real issue". Please provide an example setup (how do you initialize the plugin, extra settings, Browser etc). Thanks!

[DrDeath72]

replace russian 'ъ' and 'ь' to '' not to invalid '-'

[DrDeath72]

My code

to.slugify(from, {
    replaceMap: {
        'а': 'a', 'б': 'b', 'в': 'v', 'г': 'g', 'д': 'd', 'е': 'e',
         'ё': 'e', 'ж': 'zh', 'з': 'z', 'и': 'i', 'й': 'y', 'к': 'k', 
        'л': 'l', 'м': 'm', 'н': 'n', 'о': 'o', 'п': 'p', 'р': 'r',
         'с': 's', 'т': 't', 'у': 'u', 'ф': 'f', 'х': 'h', 'ц': 'ts', 
        'ч': 'ch', 'ш': 'sh', 'щ': 'sch', 'ъ': '', 'ы': 'i', 'ь': '', 
        'э': 'e', 'ю': 'yu', 'я': 'ya'
    },
    whitespace: '-',
    invalid: '-',
    postSlug: function(slug) {
        return slug.replace(/-+/g, '-').replace(/^-+/g, '').replace(/-+$/g, '');
    }
});

i think invalid must apply in second step only, not in replaceMap step

        sourceString = $.trim(sourceString); // Trim
        sourceString = sourceString.toLowerCase(); // Lower Case
        $.each(options.replaceMap, function(key, value) { // Special char map
            //sourceString = sourceString.replace(new RegExp(key, 'g'), value || options.invalid);
            sourceString = sourceString.replace(new RegExp(key, 'g'), value);
        });

        sourceString = sourceString
            .replace(/\s+/g, options.whitespace) // Replace whitespace characters
            .replace(new RegExp('[^a-z0-9 ' + options.whitespace + ']', 'g'), options.invalid); // Replace invalid characters

[madflow]

Okay - my test was complete bogus + I broke the replacemap with the last commit :S

I added your changes, now this tests passes:

    test('test russian Ъ', function() {
        expect(1);
        var options = {
            'invalid': '-',
            'whitespace': '_'
        };
        strictEqual($.slugify('объезд', options), 'obezd', 'test russian Ъ');
    });

Is this the expected behavior?

[DrDeath72]

yes, it's great!

[DrDeath72]

maybe add

slug.replace(/-+/g, '-').replace(/^-+/g, '').replace(/-+$/g, '')

like option or always? for clean slugs

[madflow]

I added an extra routine for cleaning up. This is the test I came up with:

    test('test consecutive invalid and whitespace chars', function() {
        expect(5);
        var options = {
            'invalid': '-',
            'whitespace': '_'
        };
        strictEqual($.slugify('  a  ', options), 'a', 'Whitespace chars trimmed');
        strictEqual($.slugify('a   a  a', options), 'a_a_a', 'Consecutive whitespacechars deleted');
        strictEqual($.slugify('=a=a=', options), 'a-a', 'Trailing invalid characters deleted');
        strictEqual($.slugify('===a=====a==', options), 'a-a', 'Consecutive invalid characters deleted');
        strictEqual($.slugify('===a== ===a==', options), 'a-_-a', 'Consecutive invalid characters deleted - whitespace reserved');
    });