Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TW-1548 Redesign 'Advanced Features' section #1205

Merged
merged 5 commits into from
Oct 7, 2024
Merged

TW-1548 Redesign 'Advanced Features' section #1205

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d5e15f8
TW-1548 Redesign 'Advanced Features' section
keshan3262 Oct 1, 2024
f57b9f8
TW-1548 Some refactoring
keshan3262 Oct 1, 2024
151862b
TW-1548 Remove old EnablingSetting component
keshan3262 Oct 1, 2024
714529f
TW-1548 Remove unused exports
keshan3262 Oct 1, 2024
1e163b3
TW-1548 Refactoring according to comments
keshan3262 Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
TW-1548 Some refactoring
  • Loading branch information
@keshan3262
keshan3262 committed Oct 1, 2024
commit f57b9f81759dc174a043cfdddca28c8874a7b4a4
2 changes: 0 additions & 2 deletions e2e/src/page-objects/pages/general-settings.page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ export class GeneralSettingsPage extends Page {
extensionLockUpCheckBox = createPageElement(SettingsGeneralSelectors.extensionLockUpCheckBox);
anonymousAnalyticsCheckBox = createPageElement(SettingsGeneralSelectors.anonymousAnalyticsCheckBox);
notificationCheckBox = createPageElement(SettingsGeneralSelectors.notificationCheckBox);
partnersPromotion = createPageElement(SettingsGeneralSelectors.partnersPromotion);

async isVisible() {
await this.languageDropDown.waitForDisplayed();
Expand All @@ -21,6 +20,5 @@ export class GeneralSettingsPage extends Page {
await this.extensionLockUpCheckBox.waitForDisplayed();
await this.anonymousAnalyticsCheckBox.waitForDisplayed();
await this.notificationCheckBox.waitForDisplayed();
await this.partnersPromotion.waitForDisplayed();
}
}
2 changes: 1 addition & 1 deletion src/app/layouts/Dialogs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React, { FC, useCallback } from 'react';

import { AlertModal } from 'app/templates/AlertModal';
import ConfirmationModal from 'app/templates/ConfirmationModal/ConfirmationModal';
import { ConfirmationModal } from 'app/templates/ConfirmationModal/ConfirmationModal';
import { dispatchAlertClose, dispatchConfirmClose, useModalsParams } from 'lib/ui/dialog';

const Dialogs: FC = () => {
Expand Down
4 changes: 1 addition & 3 deletions src/app/templates/ConfirmationModal/ConfirmationModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export interface ConfirmationModalProps extends ActionModalProps {
onConfirm: EmptyFn;
}

const ConfirmationModal = memo<ConfirmationModalProps>(
export const ConfirmationModal = memo<ConfirmationModalProps>(
({
onClose,
isOpen,
Expand Down Expand Up @@ -53,5 +53,3 @@ const ConfirmationModal = memo<ConfirmationModalProps>(
</ActionModal>
) : null
);

export default ConfirmationModal;
Loading