Release 1.19.4 (#1052)

Merge pull request #1052 from madfish-solutions/development

.eslintrc

@@ -5,7 +5,7 @@
     "plugin:import/warnings",
     "plugin:import/typescript"
   ],
-  "plugins": ["import", "prettier"],
+  "plugins": ["import", "prettier", "no-type-assertion"],
   "parser": "@typescript-eslint/parser",
   "overrides": [{
     "files": ["*.ts", "*.tsx"],
@@ -51,9 +51,12 @@
         "newlines-between": "always"
       }
     ],
+    "no-type-assertion/no-type-assertion": "warn",
     "@typescript-eslint/await-thenable": "error",
     "@typescript-eslint/no-non-null-assertion": "warn",
     "react-hooks/rules-of-hooks": "warn",
-    "react-hooks/exhaustive-deps": "warn"
+    "react-hooks/exhaustive-deps": ["warn", {
+      "additionalHooks": "(useMemoWithCompare|useDidUpdate)"
+    }]
   }
 }

.github/workflows/manual-builds.yml

@@ -80,6 +80,7 @@ jobs:
           LONG_HD_ACCOUNT_FIRST_HASH_SHORT_FORM: ${{ secrets.LONG_HD_ACCOUNT_FIRST_HASH_SHORT_FORM }}
           CUSTOM_NETWORK_RPC_URL: ${{ secrets.CUSTOM_NETWORK_RPC_URL }}
           CUSTOM_NETWORK_SECOND_RPC_URL: ${{ secrets.CUSTOM_NETWORK_SECOND_RPC_URL }}
+          NOTIFICATION_AUTHORIZATION: ${{ secrets.NOTIFICATION_AUTHORIZATION }}
 
       - name: Install dependencies and code quality
         uses: ./.github/workflows/code-quality-check

.github/workflows/secrets-setup/action.yml

@@ -70,6 +70,8 @@ inputs:
     required: false
   CUSTOM_NETWORK_SECOND_RPC_URL:
     required: false
+  NOTIFICATION_AUTHORIZATION:
+    required: false
 
 runs:
   using: 'composite'
@@ -101,6 +103,8 @@ runs:
       shell: bash
       run: |
         cat << EOF > e2e/.env
+        TEMPLE_WALLET_API_URL=${{ inputs.TEMPLE_WALLET_API_URL }}
+
         DEFAULT_HD_ACCOUNT_SEED_PHRASE=${{ inputs.DEFAULT_HD_ACCOUNT_SEED_PHRASE }}
         DEFAULT_HD_ACCOUNT_FIRST_PRIVATE_KEY=${{ inputs.DEFAULT_HD_ACCOUNT_FIRST_PRIVATE_KEY }}
         DEFAULT_HD_ACCOUNT_FIRST_PUBLIC_KEY_HASH=${{ inputs.DEFAULT_HD_ACCOUNT_FIRST_PUBLIC_KEY_HASH }}
@@ -121,4 +125,5 @@ runs:
         LONG_HD_ACCOUNT_FIRST_HASH_SHORT_FORM=${{ inputs.LONG_HD_ACCOUNT_FIRST_HASH_SHORT_FORM }}
         CUSTOM_NETWORK_RPC_URL=${{ inputs.CUSTOM_NETWORK_RPC_URL }}
         CUSTOM_NETWORK_SECOND_RPC_URL=${{ inputs.CUSTOM_NETWORK_SECOND_RPC_URL }}
+        NOTIFICATION_AUTHORIZATION=${{ inputs.NOTIFICATION_AUTHORIZATION }}
         EOF

e2e/.env.dist

@@ -30,3 +30,5 @@ WATCH_ONLY_PUBLIC_KEY_HASH_SHORT_FORM=
 
 CUSTOM_NETWORK_RPC_URL=
 CUSTOM_NETWORK_SECOND_RPC_URL=
+
+NOTIFICATION_AUTHORIZATION=

e2e/package.json

@@ -23,6 +23,7 @@
     "start:reveal_mnemonic": "yarn start --tags @reveal_mnemonic",
     "start:send": "yarn start --tags @send",
     "start:swap": "yarn start --tags @swap",
+    "start:notifications": "yarn start --tags @notifications",
     "test": "yarn start --exit --tags 'not @dev'",
     "ts": "tsc --pretty"
   },

e2e/src/features/import-account-by-mnemonic.feature

@@ -77,7 +77,7 @@ Feature: Import Account by Mnemonic
     Then I check if importedAccountByPasswordShortHash is corresponded to the selected account
 
 
-@dev
+
   Scenario: Import account by mnemonic validation + negative cases
     Given I have imported an existing account
 

e2e/src/features/manage-tokens-collectibles.feature

@@ -3,6 +3,9 @@ Feature: Manage tokens + collectibles
 
   Scenario: As a user, I'd like to add tokens and collectibles to my wallet [Positive]
     Given I have imported an existing account
+    And I press Selected Network Button on the Header page
+    And I select ECAD Labs Mainnet node in the networks drop-down list on the Header page
+    And I check that ECAD Labs Mainnet node is selected correctly
     And I press Manage Dropdown Button on the Assets page
     And I press Manage Button on the Assets (Manage Dropdown) page
 
@@ -28,6 +31,9 @@ Feature: Manage tokens + collectibles
 @manage_assets
   Scenario: As a user, I'd like to hide and delete tokens [Positive]
     Given I have imported an existing account
+    And I press Selected Network Button on the Header page
+    And I select ECAD Labs Mainnet node in the networks drop-down list on the Header page
+    And I check that ECAD Labs Mainnet node is selected correctly
 #  hardcoded token
 
     And I press Manage Dropdown Button on the Assets page
@@ -83,6 +89,9 @@ Feature: Manage tokens + collectibles
 @manage_assets
   Scenario: Validation check on Add Asset page + other checks [Negative]
     Given I have imported an existing account
+    And I press Selected Network Button on the Header page
+    And I select ECAD Labs Mainnet node in the networks drop-down list on the Header page
+    And I check that ECAD Labs Mainnet node is selected correctly
 
     And I press Manage Dropdown Button on the Assets page
     And I press Manage Button on the Assets (Manage Dropdown) page

e2e/src/features/notifications.feature

@@ -0,0 +1,42 @@
+Feature: Notifications
+  @notifications
+  Scenario: As a user, I'd like to read some news
+    Given I make request for creating a notification
+    And I have imported an existing account
+    And I press Notification Icon Button on the Home page
+
+    And I am on the NotificationsList page
+    And I check that new notification is displayed
+    And I click on the new notification
+
+    And I am on the NotificationContent page
+    And The Notification Title Text on the Notification Content page has correct Test Title value
+    And The Notification Description Text on the Notification Content page has correct Test content value
+
+    And I press Got it Button on the Notification Content page
+    And I am on the NotificationsList page
+
+    And I press Account Icon on the Header page
+    And I am on the AccountsDropdown page
+
+    And I press Settings Button on the Account Drop-down page
+    And I am on the Settings page
+
+    And I press General Button on the Settings page
+    And I am on the GeneralSettings page
+#    turning off notifications
+    And I scroll 900 pixels on the GeneralSettings page
+    And I press Notification Check Box on the Setting General page
+
+    And I scroll -900 pixels on the GeneralSettings page
+    And I press Temple Logo Icon on the Header page
+    And I am on the Home page
+
+    And I press Notification Icon Button on the Home page
+    And I am on the NotificationsList page
+
+    Then I check that new notification is NOT displayed
+
+
+
+

e2e/src/features/send.feature

@@ -52,19 +52,3 @@ Feature: Send
     And I'm waiting for 'success ✓' operation status
 
     And I am on the Send page
-# Send NFT
-    And I press Asset Drop-down on the Send Form page
-    And I clear Asset Drop-down Search Input value on the Send Form page
-    And I enter OBJKTCOM into Asset Drop-down Search Input on the Send Form page
-    And I select OBJKTCOM token in the token drop-down list on the Send page
-    And I enter watchOnlyPublicKey into Recipient Input on the Send Form page
-    And I enter amount_1 into Amount Input on the Send Form page
-    And I press Send Button on the Send Form page
-
-    And I am on the InternalConfirmation page
-    And I press Confirm Button on the Internal Confirmation page
-
-    And I am on the OperationStatusAlert page
-    And I'm waiting for 'success ✓' operation status
-
-    Then I am on the Send page

e2e/src/page-objects/index.ts

@@ -2,10 +2,14 @@ import { AddAssetPage } from 'e2e/src/page-objects/pages/add-asset.page';
 import { AddressBookPage } from 'e2e/src/page-objects/pages/address-book.page';
 import { ConfirmationModalPage } from 'e2e/src/page-objects/pages/confirmation-modal.page';
 import { NetworksDropDown } from 'e2e/src/page-objects/pages/drop-down-lists/networks.drop-down';
+// eslint-disable-next-line import/namespace
+import { GeneralSettingsPage } from 'e2e/src/page-objects/pages/general-settings.page';
 import { ManageAssetsCollectiblesPage } from 'e2e/src/page-objects/pages/manage-assets-collectibles.page';
 import { ManageAssetsTokensPage } from 'e2e/src/page-objects/pages/manage-assets-tokens.page';
 import { NetworksPage } from 'e2e/src/page-objects/pages/networks.page';
 import { NewsletterModalPage } from 'e2e/src/page-objects/pages/newsletter-modal.page';
+import { NotificationContentPage } from 'e2e/src/page-objects/pages/notification-content.page';
+import { NotificationsListPage } from 'e2e/src/page-objects/pages/notifications-list.page';
 import { OnRumModalPage } from 'e2e/src/page-objects/pages/on-rum-modal.page';
 import {
   OnboardingCongratsPage,
@@ -79,5 +83,8 @@ export const Pages = {
   OnboardingSecondStep: new OnboardingSecondStepPage(),
   OnboardingThirdStep: new OnboardingThirdStepPage(),
   OnboardingFourthStep: new OnboardingFourthStepPage(),
-  OnboardingCongrats: new OnboardingCongratsPage()
+  OnboardingCongrats: new OnboardingCongratsPage(),
+  NotificationsList: new NotificationsListPage(),
+  NotificationContent: new NotificationContentPage(),
+  GeneralSettings: new GeneralSettingsPage()
 };

e2e/src/page-objects/pages/general-settings.page.ts

@@ -0,0 +1,29 @@
+import { SettingsGeneralSelectors } from 'src/app/templates/SettingsGeneral/selectors';
+
+import { Page } from '../../classes/page.class';
+import { createPageElement } from '../../utils/search.utils';
+
+export class GeneralSettingsPage extends Page {
+  languageitem = createPageElement(SettingsGeneralSelectors.languageitem);
+  languageDropDown = createPageElement(SettingsGeneralSelectors.languageDropDown);
+  currencyItem = createPageElement(SettingsGeneralSelectors.currencyItem);
+  currenctyDropDown = createPageElement(SettingsGeneralSelectors.currenctyDropDown);
+  blockExplorerItem = createPageElement(SettingsGeneralSelectors.blockExplorerItem);
+  blockExplorerDropDown = createPageElement(SettingsGeneralSelectors.blockExplorerDropDown);
+  popUpCheckBox = createPageElement(SettingsGeneralSelectors.popUpCheckBox);
+  extensionLockUpCheckBox = createPageElement(SettingsGeneralSelectors.extensionLockUpCheckBox);
+  anonymousAnalyticsCheckBox = createPageElement(SettingsGeneralSelectors.anonymousAnalyticsCheckBox);
+  notificationCheckBox = createPageElement(SettingsGeneralSelectors.notificationCheckBox);
+  partnersPromotion = createPageElement(SettingsGeneralSelectors.partnersPromotion);
+
+  async isVisible() {
+    await this.languageDropDown.waitForDisplayed();
+    await this.currenctyDropDown.waitForDisplayed();
+    await this.blockExplorerDropDown.waitForDisplayed();
+    await this.popUpCheckBox.waitForDisplayed();
+    await this.extensionLockUpCheckBox.waitForDisplayed();
+    await this.anonymousAnalyticsCheckBox.waitForDisplayed();
+    await this.notificationCheckBox.waitForDisplayed();
+    await this.partnersPromotion.waitForDisplayed();
+  }
+}

e2e/src/page-objects/pages/import-account-tabs/import-account-mnemonic-tab.page.ts

@@ -1,8 +1,8 @@
 import { ImportAccountSelectors } from 'src/app/pages/ImportAccount/selectors';
 
 import { Page } from 'e2e/src/classes/page.class';
-import { EMPTY_WORD_FOR_INPUTS } from 'e2e/src/utils/input-data.utils';
-import { clearDataFromInput, createPageElement, findElement, findElements } from 'e2e/src/utils/search.utils';
+import { EMPTY_WORD_FOR_INPUTS, clearDataFromCurrentInput } from 'e2e/src/utils/input-data.utils';
+import { createPageElement, findElement, findElements } from 'e2e/src/utils/search.utils';
 import { SHORT_TIMEOUT } from 'e2e/src/utils/timing.utils';
 
 export class ImportAccountMnemonicTab extends Page {
@@ -35,7 +35,7 @@ export class ImportAccountMnemonicTab extends Page {
       const input = wordsInputs[i];
 
       await input.focus();
-      await clearDataFromInput();
+      await clearDataFromCurrentInput();
     }
   }
 

e2e/src/page-objects/pages/importing-existing-wallet.page.ts

@@ -1,7 +1,9 @@
 import { ImportFromSeedPhraseSelectors } from 'src/app/pages/NewWallet/import/ImportSeedPhrase/ImportFromSeedPhrase.selectors';
 
+import { clearDataFromCurrentInput } from 'e2e/src/utils/input-data.utils';
+
 import { Page } from '../../classes/page.class';
-import { clearDataFromInput, createPageElement, findElements } from '../../utils/search.utils';
+import { createPageElement, findElements } from '../../utils/search.utils';
 
 export class ImportExistingWalletPage extends Page {
   nextButton = createPageElement(ImportFromSeedPhraseSelectors.nextButton);
@@ -31,7 +33,7 @@ export class ImportExistingWalletPage extends Page {
       const input = wordsInputs[i];
 
       await input.focus();
-      await clearDataFromInput();
+      await clearDataFromCurrentInput();
     }
   }
 }

e2e/src/page-objects/pages/manage-assets-collectibles.page.ts

@@ -1,4 +1,4 @@
-import { ManageAssetsSelectors } from 'src/app/pages/ManageAssets/ManageAssets.selectors';
+import { ManageAssetsSelectors } from 'src/app/pages/ManageAssets/selectors';
 
 import { Page } from '../../classes/page.class';
 import { createPageElement } from '../../utils/search.utils';

e2e/src/page-objects/pages/manage-assets-tokens.page.ts

@@ -1,5 +1,5 @@
 import retry from 'async-retry';
-import { ManageAssetsSelectors } from 'src/app/pages/ManageAssets/ManageAssets.selectors';
+import { ManageAssetsSelectors } from 'src/app/pages/ManageAssets/selectors';
 
 import { RETRY_OPTIONS, SHORT_TIMEOUT, VERY_SHORT_TIMEOUT } from 'e2e/src/utils/timing.utils';
 

e2e/src/page-objects/pages/notification-content.page.ts

@@ -0,0 +1,16 @@
+import { NotificationsContentSelectors } from 'src/lib/notifications/components/item/notifications-content.selectors';
+
+import { Page } from '../../classes/page.class';
+import { createPageElement } from '../../utils/search.utils';
+
+export class NotificationContentPage extends Page {
+  notificationContentTitle = createPageElement(NotificationsContentSelectors.notificationContentTitle);
+  notificationContentDescription = createPageElement(NotificationsContentSelectors.notificationContentDescription);
+  gotItButton = createPageElement(NotificationsContentSelectors.gotItButton);
+
+  async isVisible() {
+    await this.notificationContentTitle.waitForDisplayed();
+    await this.notificationContentDescription.waitForDisplayed();
+    await this.gotItButton.waitForDisplayed();
+  }
+}

e2e/src/page-objects/pages/notifications-list.page.ts

@@ -0,0 +1,55 @@
+import { PreviewItemSelectors } from 'src/lib/notifications/components/notifications/preview-item.selectors';
+import type { NotificationInterface } from 'src/lib/notifications/types';
+
+import { VERY_SHORT_TIMEOUT } from 'e2e/src/utils/timing.utils';
+
+import { Page } from '../../classes/page.class';
+import { createPageElement } from '../../utils/search.utils';
+
+export class NotificationsListPage extends Page {
+  newNotification?: NotificationInterface;
+  notificationItem = createPageElement(PreviewItemSelectors.notificationItem);
+  notificationItemTitleText = createPageElement(PreviewItemSelectors.notificationItemTitleText);
+  notificationItemDescriptionText = createPageElement(PreviewItemSelectors.notificationItemDescriptionText);
+
+  async isVisible() {
+    await this.notificationItem.waitForDisplayed();
+    await this.notificationItemTitleText.waitForDisplayed();
+    await this.notificationItemDescriptionText.waitForDisplayed();
+  }
+
+  async isNotificationDisplayed({ id, title, description }: NotificationInterface) {
+    const notificationTextPageElem = createPageElement(PreviewItemSelectors.notificationItem, { id: String(id) });
+
+    await notificationTextPageElem.waitForDisplayed(
+      VERY_SHORT_TIMEOUT,
+      `Notification with ${title} title is not displayed`
+    );
+
+    const titleText = await notificationTextPageElem
+      .createChildElement(PreviewItemSelectors.notificationItemTitleText)
+      .getText();
+    if (titleText !== title) throw new Error(`Notification title missmatch. Got: ${titleText}`);
+
+    const descriptionText = await notificationTextPageElem
+      .createChildElement(PreviewItemSelectors.notificationItemDescriptionText)
+      .getText();
+    if (descriptionText !== description) throw new Error(`Notification description missmatch. Got: ${descriptionText}`);
+  }
+
+  async clickOnTheNotification({ id }: NotificationInterface) {
+    const notificationTextElem = createPageElement(PreviewItemSelectors.notificationItem, { id: String(id) });
+    await notificationTextElem.click();
+  }
+
+  async isNotificationNotDisplayed({ id, title }: NotificationInterface) {
+    const notificationTextElem = createPageElement(PreviewItemSelectors.notificationItem, { id: String(id) });
+
+    await notificationTextElem.waitForDisplayed(1_500).then(
+      () => {
+        throw new Error(`The notification '${title}' is displayed after turning off 'news' checkbox in settings`);
+      },
+      () => undefined
+    );
+  }
+}

e2e/src/step-definitions/common.steps.ts

@@ -2,8 +2,8 @@ import { Given } from '@cucumber/cucumber';
 
 import { BrowserContext } from '../classes/browser-context.class';
 import { Pages } from '../page-objects';
-import { iEnterValues, IEnterValuesKey } from '../utils/input-data.utils';
-import { clearDataFromInput, createPageElement } from '../utils/search.utils';
+import { iEnterValues, IEnterValuesKey, clearDataFromCurrentInput } from '../utils/input-data.utils';
+import { createPageElement } from '../utils/search.utils';
 import { LONG_TIMEOUT, MEDIUM_TIMEOUT, SHORT_TIMEOUT } from '../utils/timing.utils';
 
 Given(/^I am on the (\w+) page$/, { timeout: LONG_TIMEOUT }, async (page: keyof typeof Pages) => {
@@ -20,7 +20,7 @@ Given(
   async (elementName: string, pageName: string) => {
     const element = createPageElement(`${pageName}/${elementName}`);
     await element.click();
-    await clearDataFromInput();
+    await clearDataFromCurrentInput();
   }
 );