TW-1544: [evm] Networks management (#1202)

* TW-1555 Update some design and fix some bugs * TW-1555 Make some modals close after their backdrop is clicked * TW-1542 Resolve merge conflicts * TW-1542 Revert harmful changes * TW-1542 Remove unused components * TW-1542 Implement new Settings menu design * TW-1542 Remove some unused translations * TW-1542 Fix find-deadcode errors * TW-1542 Add changes from comments * TW-1543 Redesign 'General' settings section * TW-1543 Refactoring * TW-1542 Move localStorage clearing to frontend * TW-1542 Update a label * TW-1555 Some more bugfixes * TW-1543 Change error output * TW-1543 Apply design updates * TW-1555 Remove some commented out code * TW-1543 Remove excessive locales loading checks * TW-1555 Refactor setting classes Co-authored-by: Alex <alexseleznov@madfish.solutions> * TW-1555 Fix prettier problem * TW-1555 Agree styles for app content wrapper and action modals * TW-1543 Bugfixes according to the comment from Figma * TW-1542 Change a label * TW-1542 Fix font size for page header * TW-1543 Remove an unused import * TW-1544 Implement RPCs and block explorers management (raw version) * TW-1544 Fix some bugs * TW-1542: Apply design for settings menu (#1199) * TW-1555 Update some design and fix some bugs * TW-1555 Make some modals close after their backdrop is clicked * TW-1542 Resolve merge conflicts * TW-1542 Revert harmful changes * TW-1542 Remove unused components * TW-1542 Implement new Settings menu design * TW-1542 Remove some unused translations * TW-1542 Fix find-deadcode errors * TW-1542 Add changes from comments * TW-1542 Move localStorage clearing to frontend * TW-1542 Update a label * TW-1555 Some more bugfixes * TW-1555 Remove some commented out code * TW-1555 Refactor setting classes Co-authored-by: Alex <alexseleznov@madfish.solutions> * TW-1555 Fix prettier problem * TW-1555 Agree styles for app content wrapper and action modals * TW-1542 Change a label * TW-1542 Fix font size for page header --------- Co-authored-by: Alex <alexseleznov@madfish.solutions> * TW-1543: 'General' section update (#1200) * TW-1555 Update some design and fix some bugs * TW-1555 Make some modals close after their backdrop is clicked * TW-1542 Resolve merge conflicts * TW-1542 Revert harmful changes * TW-1542 Remove unused components * TW-1542 Implement new Settings menu design * TW-1542 Remove some unused translations * TW-1542 Fix find-deadcode errors * TW-1542 Add changes from comments * TW-1543 Redesign 'General' settings section * TW-1543 Refactoring * TW-1542 Move localStorage clearing to frontend * TW-1542 Update a label * TW-1555 Some more bugfixes * TW-1543 Change error output * TW-1543 Apply design updates * TW-1555 Remove some commented out code * TW-1543 Remove excessive locales loading checks * TW-1555 Refactor setting classes Co-authored-by: Alex <alexseleznov@madfish.solutions> * TW-1555 Fix prettier problem * TW-1555 Agree styles for app content wrapper and action modals * TW-1543 Bugfixes according to the comment from Figma * TW-1542 Change a label * TW-1542 Fix font size for page header * TW-1543 Remove an unused import --------- Co-authored-by: Alex <alexseleznov@madfish.solutions> * TW-1544 Implement whole networks management * TW-1544 Some bugfixes * TW-1544 Some bugfixes * TW-1544 Additional refactoring * TW-1544 Major refactoring * TW-1544 Refactoring according to comments * TW-1544 Fix a linting error * TW-1544 Additional refactoring according to comments * TW-1548: Redesign 'Advanced Features' section (#1205) * TW-1548 Redesign 'Advanced Features' section * TW-1548 Some refactoring * TW-1548 Remove old EnablingSetting component * TW-1548 Remove unused exports * TW-1548 Refactoring according to comments * Fix some bugs from comments in Jira * TW-1544 Fix rest of bugs from comments in Jira * TW-1544 Implmenent reserving space for an error below FormField * TW-1544 Remove an unused import * TW-1544 Prevent disabling main Tezos and EVM networks * TW-1544 Minor refactoring --------- Co-authored-by: Alex <alexseleznov@madfish.solutions>
madfish-solutions · Oct 30, 2024 · 63c9e85 · 63c9e85
1 parent 9af1789
commit 63c9e85
Show file tree

Hide file tree

Showing 111 changed files with 3,676 additions and 1,303 deletions.
diff --git a/e2e/src/page-objects/index.ts b/e2e/src/page-objects/index.ts
@@ -5,7 +5,6 @@ import { ConfirmationModalPage } from '../page-objects/pages/confirmation-modal.
 import { GeneralSettingsPage } from '../page-objects/pages/general-settings.page';
 import { HomePage } from '../page-objects/pages/home.page';
 import { BackupOptionsModalPage } from '../page-objects/pages/modal/backup-options-modal.page';
-import { NetworksPage } from '../page-objects/pages/networks.page';
 import { NotificationContentPage } from '../page-objects/pages/notification-content.page';
 import { NotificationsListPage } from '../page-objects/pages/notifications-list.page';
 import { SwapPage } from '../page-objects/pages/swap.page';
@@ -40,7 +39,7 @@ export const Pages = {
   Swap: new SwapPage(),
   AddressBook: new AddressBookPage(),
   ConfirmationModal: new ConfirmationModalPage(),
-  Networks: new NetworksPage(),
+  // TODO: add tests for networks settings
   CollectiblePage: new CollectiblePage(),
   CollectiblesTabPage: new CollectiblesTabPage(),
   NotificationsList: new NotificationsListPage(),

diff --git a/e2e/src/page-objects/pages/networks.page.ts b/e2e/src/page-objects/pages/networks.page.ts
diff --git a/package.json b/package.json
@@ -172,6 +172,7 @@
     "react-dev-utils": "^12",
     "react-dom": "18.2.0",
     "react-hook-form": "5.3.1",
+    "react-hook-form-v7": "npm:react-hook-form@7.53.0",
     "react-hot-toast": "^2.4.1",
     "react-infinite-scroll-component": "^6.1.0",
     "react-json-view": "1.21.3",

diff --git a/public/_locales/en/messages.json b/public/_locales/en/messages.json
@@ -243,6 +243,9 @@
       }
     }
   },
+  "networkEnabled": {
+    "message": "Network Enabled"
+  },
   "pkhLabel": {
     "message": "Account: $pkh$",
     "placeholders": {
@@ -2199,6 +2202,129 @@
   "defaultAccount": {
     "message": "Default account (the first one)"
   },
+  "defaultNetworksGroup": {
+    "message": "Default Networks"
+  },
+  "customNetworksGroup": {
+    "message": "Custom Networks"
+  },
+  "chainTestnetsGroup": {
+    "message": "$chain$ Testnets",
+    "placeholders": {
+      "chain": {
+        "content": "$1"
+      }
+    }
+  },
+  "customTestnetsGroup": {
+    "message": "Custom Testnets"
+  },
+  "active": {
+    "message": "Active"
+  },
+  "rpcEndpoints": {
+    "message": "RPC Endpoints"
+  },
+  "activeRpc": {
+    "message": "Active RPC"
+  },
+  "activeBlockExplorer": {
+    "message": "Active"
+  },
+  "deleteRpc": {
+    "message": "Delete RPC"
+  },
+  "deleteBlockExplorer": {
+    "message": "Delete"
+  },
+  "rpcAdded": {
+    "message": "RPC added"
+  },
+  "blockExplorerAdded": {
+    "message": "Block explorer added"
+  },
+  "invalidChainId": {
+    "message": "Invalid chain ID"
+  },
+  "chainId": {
+    "message": "Chain ID"
+  },
+  "chainIdTooltip": {
+    "message": "The chain ID is used for signing transactions. It must match the chain ID returned by the network."
+  },
+  "blockExplorerUrl": {
+    "message": "Block explorer URL"
+  },
+  "testnet": {
+    "message": "Testnet"
+  },
+  "removeNetwork": {
+    "message": "Remove Network"
+  },
+  "removeNetworkModalTitleLeftPart": {
+    "message": "Remove "
+  },
+  "removeNetworkModalTitleRightPart": {
+    "message": "?"
+  },
+  "removeNetworkModalDescription": {
+    "message": "You won’t be able to check the assets on this\nnetwork anymore."
+  },
+  "editSomeRpcLeftPart": {
+    "message": "Edit "
+  },
+  "editSomeRpcRightPart": {
+    "message": " RPC"
+  },
+  "editSomeBlockExplorerLeftPart": {
+    "message": "Edit "
+  },
+  "editSomeBlockExplorerRightPart": {
+    "message": ""
+  },
+  "rpcDoesNotRespond": {
+    "message": "RPC doesn’t respond"
+  },
+  "rpcDoesNotMatchChain": {
+    "message": "RPC doesn’t match chain"
+  },
+  "wrongAddress": {
+    "message": "Wrong address"
+  },
+  "addSomeRpc": {
+    "message": "Add $network$ RPC",
+    "placeholders": {
+      "network": {
+        "content": "$1"
+      }
+    }
+  },
+  "addSomeBlockExplorer": {
+    "message": "Add $network$ explorer",
+    "placeholders": {
+      "network": {
+        "content": "$1"
+      }
+    }
+  },
+  "confirmDeleteRpcTitleLeftPart": {
+    "message": "Delete "
+  },
+  "confirmDeleteRpcTitleRightPart": {
+    "message": " RPC?"
+  },
+  "confirmDeleteRpcDescription": {
+    "message": "This will remove the RPC from the list and automatically switch the network to the default RPC endpoint."
+  },
+  "confirmDeleteBlockExplorerTitleLeftPart": {
+    "message": "Delete "
+  },
+  "confirmDeleteBlockExplorerTitleRightPart": {
+    "message": "?"
+  },
+  "confirmDeleteBlockExplorerDescription": {
+    "message": "This will remove the block explorer from the list and automatically switch the network to the default one."
+  },
   "loadMore": {
     "message": "Load more"
   },
@@ -2211,6 +2337,14 @@
   "invalidJsonInput": {
     "message": "Invalid JSON"
   },
+  "anotherChainIdError": {
+    "message": "The chain ID used by RPC is $chainId$",
+    "placeholders": {
+      "chainId": {
+        "content": "$1"
+      }
+    }
+  },
   "unknownErrorFromRPC": {
     "message": "Failed to send request to $url$. Invalid request provided or RPC node is temporarily unreachable.",
     "placeholders": {
@@ -2300,7 +2434,7 @@
     "message": "Feel free to join and ask your questions 😊"
   },
   "blockExplorer": {
-    "message": "Blockchain explorer"
+    "message": "Block Explorer"
   },
   "viewOnBlockExplorer": { "message": "View on block explorer" },
   "specifyTokenId": {

diff --git a/src/app/PageRouter.tsx b/src/app/PageRouter.tsx
@@ -22,7 +22,9 @@ import { usePageRouterAnalytics } from 'lib/analytics';
 import { Notifications, NotificationsItem } from 'lib/notifications/components';
 import { useTempleClient } from 'lib/temple/front';
 import * as Woozie from 'lib/woozie';
+import { TempleChainKind } from 'temple/types';
 
+import { ChainSettings } from './pages/ChainSettings';
 import { ImportWallet } from './pages/ImportWallet';
 import { Market } from './pages/Market';
 import { StakingPage } from './pages/Staking';
@@ -90,6 +92,10 @@ const ROUTE_MAP = Woozie.createMap<RouteContext>([
       <CollectiblePage chainKind={chainKind!} chainId={chainId!} assetSlug={assetSlug!} />
     ))
   ],
+  [
+    '/settings/networks/:chainKind/:chainId',
+    onlyReady(({ chainId, chainKind }) => <ChainSettings chainKind={chainKind as TempleChainKind} chainId={chainId!} />)
+  ],
   ['/settings/:tabSlug?', onlyReady(({ tabSlug }) => <Settings tabSlug={tabSlug} />)],
   ['/market', onlyReady(onlyInFullPage(() => <Market />))],
   ['/buy/crypto/exolix', onlyReady(onlyInFullPage(() => <Exolix />))],

diff --git a/src/app/atoms/FilterButton.tsx b/src/app/atoms/FilterButton.tsx
@@ -7,7 +7,7 @@ import { ReactComponent as FilterOffIcon } from 'app/icons/base/filteroff.svg';
 import { ReactComponent as FilterOnIcon } from 'app/icons/base/filteron.svg';
 import { useAssetsFilterOptionsSelector } from 'app/store/assets-filter-options/selectors';
 import { AssetsFilterOptionsInitialState } from 'app/store/assets-filter-options/state';
-import { ACTIVE_STYLED_BUTTON_COLORS_CLASSNAME } from 'lib/ui/button-like-styles';
+import { ACTIVE_STYLED_BUTTON_COLORS_CLASSNAME } from 'lib/ui/use-styled-button-or-link-props';
 
 import { Button } from './Button';
 import { IconBase } from './IconBase';

diff --git a/src/app/atoms/FormField.tsx b/src/app/atoms/FormField.tsx
@@ -43,6 +43,7 @@ export interface FormFieldProps extends TestIDProperty, Omit<FormFieldAttrs, 'ty
   labelWarning?: ReactNode;
   errorCaption?: ReactNode;
   shouldShowErrorCaption?: boolean;
+  reserveSpaceForError?: boolean;
   warning?: boolean;
   containerClassName?: string;
   labelContainerClassName?: string;
@@ -90,6 +91,7 @@ export const FormField = forwardRef<FormFieldElement, FormFieldProps>(
       labelWarning,
       errorCaption,
       shouldShowErrorCaption = true,
+      reserveSpaceForError = true,
       warning = false,
       containerClassName,
       labelContainerClassName,
@@ -257,7 +259,12 @@ export const FormField = forwardRef<FormFieldElement, FormFieldProps>(
           {secretCovered && <SecretCover onClick={handleSecretBannerClick} />}
         </div>
 
-        {shouldShowErrorCaption && <ErrorCaption errorCaption={errorCaption} />}
+        {shouldShowErrorCaption &&
+          (reserveSpaceForError && !errorCaption ? (
+            <div className="size-4" />
+          ) : (
+            <ErrorCaption errorCaption={errorCaption} />
+          ))}
       </div>
     );
   }

diff --git a/src/app/atoms/IconBase.tsx b/src/app/atoms/IconBase.tsx
@@ -4,7 +4,7 @@ import clsx from 'clsx';
 
 export type Size = 12 | 16 | 24 | 32;
 
-interface Props {
+export interface IconBaseProps {
   /** SVG of the 16px icon base container */
   Icon: ImportedSVGComponent;
   size?: Size;
@@ -13,7 +13,7 @@ interface Props {
 }
 
 /** For monochrome icons */
-export const IconBase = memo<Props>(({ size = 16, className, Icon, onClick }) => (
+export const IconBase = memo<IconBaseProps>(({ size = 16, className, Icon, onClick }) => (
   <div data-icon-size={size} className={clsx(CONTAINER_CLASSNAME[size], className)} onClick={onClick}>
     <Icon className="w-full h-full stroke-current fill-current" transform={SCALE_TRANSFORMS[size]} />
   </div>

diff --git a/src/app/atoms/IconButton.tsx b/src/app/atoms/IconButton.tsx
@@ -6,7 +6,7 @@ import {
   StyledButtonColor,
   ACTIVE_STYLED_BUTTON_COLORS_CLASSNAME,
   getStyledButtonColorsClassNames
-} from 'lib/ui/button-like-styles';
+} from 'lib/ui/use-styled-button-or-link-props';
 import useTippy from 'lib/ui/useTippy';
 import { combineRefs } from 'lib/ui/utils';
 

diff --git a/src/app/atoms/PageModal/actions-buttons-box.tsx b/src/app/atoms/PageModal/actions-buttons-box.tsx
@@ -4,46 +4,45 @@ import clsx from 'clsx';
 import { throttle } from 'lodash';
 import { useDispatch } from 'react-redux';
 
-import { useAppEnv } from 'app/env';
 import { setToastsContainerBottomShiftAction } from 'app/store/settings/actions';
 
 interface ActionsButtonsBoxProps extends HTMLAttributes<HTMLDivElement> {
   shouldCastShadow?: boolean;
   flexDirection?: 'row' | 'col';
+  shouldChangeBottomShift?: boolean;
 }
 
 export const ActionsButtonsBox = memo<ActionsButtonsBoxProps>(
-  ({ className, shouldCastShadow, flexDirection = 'col', ...restProps }) => {
+  ({ className, shouldCastShadow, flexDirection = 'col', shouldChangeBottomShift = true, ...restProps }) => {
     const dispatch = useDispatch();
-    const { popup } = useAppEnv();
 
     useEffect(() => {
-      return () => void dispatch(setToastsContainerBottomShiftAction(0));
-    }, []);
+      return () => void (shouldChangeBottomShift && dispatch(setToastsContainerBottomShiftAction(0)));
+    }, [dispatch, shouldChangeBottomShift]);
 
     const handleResize = useMemo(
       () =>
         throttle<ResizeObserverCallback>(entries => {
           const borderBoxSize = entries.map(entry => entry.borderBoxSize?.[0]).filter(Boolean)[0];
 
-          if (borderBoxSize) {
-            dispatch(setToastsContainerBottomShiftAction(borderBoxSize.blockSize - (popup ? 16 : 0)));
+          if (borderBoxSize && shouldChangeBottomShift) {
+            dispatch(setToastsContainerBottomShiftAction(borderBoxSize.blockSize - 24));
           }
         }, 100),
-      [dispatch, popup]
+      [dispatch, shouldChangeBottomShift]
     );
 
     const resizeObserver = useMemo(() => new ResizeObserver(handleResize), [handleResize]);
     const rootRef = useCallback(
       (node: HTMLDivElement | null) => {
         resizeObserver.disconnect();
-        if (node) {
+        if (node && shouldChangeBottomShift) {
           resizeObserver.observe(node);
           const { height } = node.getBoundingClientRect();
           dispatch(setToastsContainerBottomShiftAction(height));
         }
       },
-      [dispatch, resizeObserver]
+      [dispatch, resizeObserver, shouldChangeBottomShift]
     );
 
     return (