Fixed another out-of-bounds vector access #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was crashing whenever the user tried to play sounds too quickly. It's likely that `sample_length` got out of sync with `samples.size()`, as they live in separate objects. I've also changed those variables to `unsigned` to avoid a warning about comparing integer expressions of different signedness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was crashing whenever the user tried to play sounds too quickly. It's likely that
sample_lengthgot out of sync withsamples.size(), as they live in separate objects.I've also changed those variables to
unsignedto avoid a warning about comparing integer expressions of different signedness.