Fix sepolia by updating bonsai-trie #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
What is the current behavior?
sepolia (testnet) sync crash
What is the new behavior?
use my fork of bonsai-trie where I have fixed some node leaks and correctness problems -- I found these problems using proptest
This fixes the problem we have with empty blocks in sepolia
This should fix the problem we have on mainnet too (?)
Does this introduce a breaking change?
I think so..? I have changed bonsai-trie internals quite a bit
The DB should be a bit lighter too as a lot of nodes were not properly removed but I havent quantified that
Other information