Addressing scenarios where filepath is missing from stack trace #51

madalinoprea · Mar 18, 2016 · 12cc820 · 12cc820
1 parent 07e75aa
commit 12cc820
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/code/Debug/Helper/Data.php b/code/Debug/Helper/Data.php
@@ -267,7 +267,7 @@ public function formatMemorySize($size, $precision = 2)
      * @param string $stripFilepath
      * @return string
      */
-    public function formatStacktrace(array $trace, $stripFilepath = '', $trimPath='')
+    public function formatStacktrace(array $trace, $stripFilepath = '', $trimPath = '')
     {
         $out = '';
         foreach ($trace as $index => $row) {
@@ -276,12 +276,17 @@ public function formatStacktrace(array $trace, $stripFilepath = '', $trimPath=''
                 continue;
             }
 
-            if ($trimPath) {
+            if ($trimPath && isset($row['file'])) {
                 $row['file'] = str_replace($trimPath, '', $row['file']);
             }
 
-            // sometimes there is undefined index 'file'
-            @$out .= "[$index] {$row['file']}:{$row['line']}\n";
+            if (isset($row['file'])) {
+                $out .= "[$index] {$row['file']}:{$row['line']}\n";
+            } else {
+                // sometimes there is undefined index 'file'
+                $out .= "[$index] (?) {$row['class']}:{$row['function']}\n";
+            }
+
         }
 
         return $out;