Fix scrollbars in Mojave dark mode not rendering properly #793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dark mode scrollbars's background are rendered in a translucent color so that it would overlay on top of the background nearly, even though we are using legacy scrollbars with a dedicated space. This is unlike light mode scrollbars which render with a concrete color. This means if the background has uncleared rendering it would result in some oddities. Just fix it by making sure we first render the scroll track with the current background color before drawing the system overlay. Known issues: - The scroll knob will look quite light and hard to see if the background color is bright. Consider this OK for now as users who use dark mode will likely have a dark-ish background color in Vim. - If both vertical and horizontal scrollbars are enabled, the corners will look black or sometimes filled with rendering artifacts. Will fix this later. One way to fix is to always fill the Vim view with a background color but that seems to slow things down a little bit because setNeedsDisplay seems to be called too much without a rect, so need to fix that first. - Vertical scrollbars' positions are sometimes set incorrectly. That's a separate bug and will be addressed later. - MacVim currently doesn't support overlay scrollbars which have been introduced in macOS since 10.7. Investigate that option too.
ychin
force-pushed
the
scrollbar_dark_mode_fix
branch
from
e732895 to
4ba02a8
Compare
ychin
added
the
UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dark mode scrollbars's background are rendered in a translucent color so that it would overlay on top of the background nearly, even though we are using legacy scrollbars with a dedicated space. This is unlike light mode scrollbars which render with a concrete color. This means if the background has uncleared rendering it would result in some oddities. Just fix it by making sure we first render the scroll track with the current background color before drawing the system overlay.
Known issues: