Replace AST cursor in soup #1292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
gbirman
reviewed
Feb 3, 2026
| cursor: SoupCursor, | ||
| ) -> Result<Json<PaginatedOpaqueCursor<SoupApiItem>>, SoupHandlerErr> { | ||
| let filters = EntityFilterAst::new_from_filters(filters)?; | ||
| // let filters = EntityFilterAst::new_from_filters(filters)?; |
Contributor
There was a problem hiding this comment.
nit do we need this comment
gbirman
approved these changes
Feb 3, 2026
seanaye
force-pushed
the
seanaye/feat/replace-ast-cursor
branch
from
a6d771f to
e623c9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the expanded ast cursor in soup to remain as the input EntityFilters struct.
This keeps the data size of the cursor small even when the file association filter expands to large values.