Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom sizes in SidebarItemsConfiguration #476

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

plarson
Copy link

@plarson plarson commented Aug 19, 2023

First PR for this repository. I needed to make the sidebar icons bigger so I reconfigured SidebarItemsConfiguration to not be private.

Pre-launch Checklist

  • I have incremented the package version as appropriate and updated CHANGELOG.md with my changes
  • I have added/updated relevant documentation
  • I have run "optimize/organize imports" on all changed files
  • I have addressed all analyzer warnings as best I could

@plarson plarson changed the title All custom sizes in SidebarItemsConfiguration Allow custom sizes in SidebarItemsConfiguration Aug 19, 2023
@plarson plarson changed the title Allow custom sizes in SidebarItemsConfiguration Allow custom sizes in SidebarItemsConfiguration Aug 19, 2023
@GroovinChip
Copy link
Collaborator

Hi @plarson and thank you for your first PR to this project.

I am not certain that making SidebarItemsConfiguration is the best technical choice to achieve the desired result. I'd lean towards adding an iconSize property to the Sidebar itself.

That said, it is not clear to me if Apple has a design opinion about this. The Human Interface Guidelines make no mention of it, and research is required to see if SwiftUI supports it. I will look into this and get back to you.

@GroovinChip GroovinChip added the research required More information is needed about the issue or PR this label is applied to label Oct 15, 2023
@GroovinChip
Copy link
Collaborator

@plarson I have the answer: https://developer.apple.com/design/human-interface-guidelines/sidebars#macOS

Please look through this and update your PR to match the specs outlined here. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
research required More information is needed about the issue or PR this label is applied to
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants