More extensibility #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makefile.rules now contains all the build rules from the old Makefile.
Targets is an external list of targets to build when 'make all' is invoked.
YourTargets is an external list of *your* targets.
Makefile unifies it all with some sugar on top.
*Your* programs don't have anything different from the regular ones,
but have their own build targets ('make mine', 'make my-benchmark').
Thus, it is possible to separate all programs into two groups: ones that
are only built once or rarely ('their hashes') and ones you actively
work on and that require constant rebuild ('your hashes', ahha!). This
'feature' is completely optional.
…ay, each program now has a method to identify itself.
…ay, each program now has a method to identify itself.
…k to template where they belong.
Conflicts: make_chart_data.py
Owner
|
Just glancing at the changes and your comments, this looks like good stuff! I will give your version a whirl within (hopefully) a few days and barring any unexpected issues I will merge your changes. Thanks! |
Conflicts: Makefile bench.py make_chart_data.py
Conflicts: Makefile bench.py
…'s ExtUtils rules).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The theme of this push is 'extensibility'. My use case for your benchmark is "pitting hash table you just wrote against common contenders". Therefore, I needed more flexibility in terms of rebuilding, adding/removing hash programs from the lists, quickly changing the scales, etc.
Commit messages are pretty extensive, but here's a quick overview:
Sorry for the useless back-and-forth commits regarding auto-adjusting axises, took several iterations to get it right, but I'm pretty happy with the final result.