Skip to content

Conversation

@kinsamanka
Copy link
Contributor

Continuation of #246

@kinsamanka
Copy link
Contributor Author

kinsamanka commented Nov 12, 2019

runtests are now part of the deb build process.

Simplified the packaging, this is now a multi-binary package, although not yet useful as i'm still figuring out some stuff.

Had to abort the build as it was going in a loop.

@zultron
Copy link
Contributor

zultron commented Nov 13, 2019

runtests are now part of the deb build process.

That's been on my wish-list for years now. Nice!

@kinsamanka kinsamanka force-pushed the cmake_test branch 3 times, most recently from 99d3b6f to a108db3 Compare November 15, 2019 15:48
@kinsamanka
Copy link
Contributor Author

This is almost done.

Next step is to convert machinekit-cnc and then fix the armhf* builds.

kinsamanka and others added 8 commits November 16, 2019 14:46
  - Replaced the old build system without affecting the git history of
    the header files. Instead of moving, they are symlinked to the build
    directory during configuring

  - Reworked and simplified the existing debian packaging. The
    libraries are now individually packaged to conform to Debian's
    standards. A lot still needs to be done.

  - There is no more special RIP builds. The resulting binaries can be
    both used for running runtests and later used for installation
CMake version 3.12 and later (Buster ships 3.13) has
`FindPython2.cmake`, and `FindPythonInterp.cmake` and
`FindPythonLibs.cmake` are deprecated.

This patch makes the CMake files forward-compatible by including
`FindPython2_local.cmake` in older CMakes, and setting needed
variables like the newer scheme.
@kinsamanka
Copy link
Contributor Author

armhf builds fine, not yet tested on a real hw though.

@zultron ,can you please add cmake and patchelf to the mk-cross-builder? 😉

@MicroTransactionsMatterToo
Copy link
Contributor

Where are we up to regarding actually implementing CMake? It seems like it's implemented for the most part so far, and we're just waiting for something?

@kinsamanka
Copy link
Contributor Author

machinekit-cnc needs to be converted too.

@kdunn926
Copy link

kdunn926 commented Feb 7, 2020

@kinsamanka - I'd be willing to poke around on that repo and see if I can make some headway. Is there a compilation doc/readme or is it the common configure / make process?

@MicroTransactionsMatterToo
Copy link
Contributor

@kdunn926 At the moment the build process is a bit convoluted. I've found the build-docker script to be best, since it won't build properly on a non-debian system. The configure script is located in /debian, and pulls from a bunch of files to setup the makefile. Subdirectories contain Submakefile's, for compiling each part of the whole codebase. I'd be willing to fiddle around as well, but I'm not an expert with CMake. The main issue as far as I can tell is migrating all the numerous Automake config files and individual Submakefiles into CMake.

@kdunn926
Copy link

@MicroTransactionsMatterToo - After spending a long day on this, I see the convolution you mentioned. 😄

Thanks for the pointers. I'm not a cmake expert by any stretch of the imagination either but it looks like I was able to wrangle a bunch of this into shape on a matching branch here. There's a couple small changes needed to @kinsamanka 's branch to make sure certain header files are available, and this work also assumes a make install was done for machinekit-hal first, to land the dependent headers. There's probably cleaner ways to pull this off but I figure this should be a good start.

It's not entirely clear to me how to test things short of just compiling and invoking the binaries manually and seeing what happens. Suggestions are welcome.

@cerna
Copy link
Contributor

cerna commented Dec 27, 2021

Super-seeded by #349.

@cerna cerna closed this Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants