Correctly detect powershell when ssh to windows machine. #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hetong07 : This would need an upstream issue and PR as well, at https://github.com/docker/machine Returning the full path sounds normal for $SHELL, for instance |
hetong07
added a commit
to hetong07/minikube
that referenced
this pull request
Mar 10, 2021
medyagh
pushed a commit
to hetong07/minikube
that referenced
this pull request
Mar 23, 2021
michaelhenkel
pushed a commit
to michaelhenkel/minikube
that referenced
this pull request
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When ssh to a windows machine, the
Detect()will return powershell.exe rather than powershell. It is due to the fact that theos.getenv()returns the absolute path to powershell rather then an empty string, which causes this issue.Related issue(s)