Fix Windows minikube ISO download #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- On Windows, `minikube` passes in a file URL like `"file://C:/Users/douglas/.minikube/cache/iso/minikube-v1.2.0.iso"`, however, due to the way that Go parses URLs, the `"C:"` part is actually parsed as the hostname portion instead of staying at the beginning of the path (golang/go#6027). If `minikube` is run with a working directory on a different drive from where its cache directory resides, it will fail since `libmachine` is only looking at the path portion (in this case: `"/Users/douglas/.minikube/cache/iso/minikube-v1.2.0.iso"`) so it fails to find the file (kubernetes/minikube#1574). Signed-off-by: Douglas Thrift <dthrift@flexera.com> (cherry picked from commit ade5501)
tstromberg
approved these changes
Oct 22, 2019
|
/cc @afbjorklund @gbraad |
|
Reported upstream as docker#4734 |
|
I dont see any activity or update on the upstream... is there any ohter way we can have this fix? |
|
@afbjorklund Let's go ahead and merge this PR in the fork, upstream isn't really accepting PRs from what I can tell. |
|
@sharifelgamal : OK, will do. can you update minikube once it is merged ? |
douglaswth
deleted the
fix_windows_minikube_iso_download_machine_drivers
branch
anjannath
pushed a commit
to anjannath/machine
that referenced
this pull request
Apr 4, 2024
Return an error when BundleName is not set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minikubepasses in a file URL like"file://C:/Users/douglas/.minikube/cache/iso/minikube-v1.2.0.iso",however, due to the way that Go parses URLs, the
"C:"part is actuallyparsed as the hostname portion instead of staying at the beginning of
the path (net/url: add test of "Windows" file URL golang/go#6027). If
minikubeis run with a working directory on a different drivefrom where its cache directory resides, it will fail since
libmachineis only looking at the path portion (in this case:"/Users/douglas/.minikube/cache/iso/minikube-v1.2.0.iso") so itfails to find the file (start fails when run from non-C:\ drive: open minikube.iso: The system cannot find the path specified. kubernetes/minikube#1574).
Signed-off-by: Douglas Thrift dthrift@flexera.com
(cherry picked from commit ade5501)
Description
Related issue(s)