Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.js #5

Merged
merged 1 commit into from
Jun 26, 2017
Merged

Update index.js #5

merged 1 commit into from
Jun 26, 2017

Conversation

XhmikosR
Copy link
Contributor

Add crossorigin="anonymous" attribute.

Fixes #3.

@macedigital: note that I couldn't get tests to pass on Windows so I couldn't extend them for this change.

PS. I'd move line 73-79 after the addIntegrityAttribute function.

Add `crossorigin="anonymous"` attribute.
@codecov-io
Copy link

codecov-io commented Jun 22, 2017

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #5   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          66     67    +1     
=====================================
+ Hits           66     67    +1
Impacted Files Coverage Δ
index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55f59d7...2a9c71c. Read the comment docs.

@macedigital
Copy link
Owner

@XhmikosR Thanks. Can you tell me which nodejs and Windows version you're using? I'd be interested to see which tests aren't working on Windows.

P.S. Currently, the code exploits hoisting, which is why function declarations are at the bottom. I am planning on refactoring the code to ES6 soon-ish.

@macedigital macedigital merged commit 5ffca49 into macedigital:master Jun 26, 2017
@XhmikosR
Copy link
Contributor Author

@macedigital: I'm using node 8 on Windows 7. You can add AppVeyor for Windows testing and I'm pretty sure you'll see the failures too.

@XhmikosR XhmikosR deleted the XhmikosR-patch-1 branch June 26, 2017 06:52
@XhmikosR
Copy link
Contributor Author

BTW, can we have a new release?

@macedigital
Copy link
Owner

@XhmikosR New release v1.3.0 is available. I just added AppVeyor and now I can see that relative path resolution fails on Windows. Created #6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants