Skip to content

Commit 7beed03

Browse files
gengjiawenmacdoum1
authored andcommitted
add RNTester to ci (facebook#19673)
Summary: * Current ci is missing an important part to test the whole part. With this we can make sure the js and android part compiles. * Ensure the current android proguard rules is okay. The `my-release-key.keystore` is just a copy of debug.keystore in `react-native/keystores`. Pass all ci. none [GENERAL] [ENHANCEMENT] [CI] - Add RNTester to ci Closes facebook#19673 Differential Revision: D8435419 Pulled By: hramos fbshipit-source-id: d3d92a5d1b8477c1f298643cc96695769e5c93ea
1 parent a511159 commit 7beed03

File tree

4 files changed

+10
-4
lines changed

4 files changed

+10
-4
lines changed

.circleci/config.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -558,6 +558,12 @@ jobs:
558558
- run: *run-android-unit-tests
559559
- run: *run-android-instrumentation-tests
560560

561+
# Build Android RNTester
562+
- run:
563+
name: Build Android RNTester
564+
command: |
565+
./gradlew RNTester:android:app:assembleRelease
566+
561567
# Collect Results
562568
- run: *collect-android-test-results
563569
- store_test_results:

RNTester/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ def enableSeparateBuildPerCPUArchitecture = false
8181
/**
8282
* Run Proguard to shrink the Java bytecode in release builds.
8383
*/
84-
def enableProguardInReleaseBuilds = false
84+
def enableProguardInReleaseBuilds = true
8585

8686
android {
8787
compileSdkVersion 26

RNTester/android/app/gradle.properties

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@ android.useDeprecatedNdk=true
22
org.gradle.parallel=true
33
org.gradle.configureondemand=true
44
MYAPP_RELEASE_STORE_FILE=my-release-key.keystore
5-
MYAPP_RELEASE_KEY_ALIAS=my-key-alias
6-
MYAPP_RELEASE_STORE_PASSWORD=*****
7-
MYAPP_RELEASE_KEY_PASSWORD=*****
5+
MYAPP_RELEASE_KEY_ALIAS=androiddebugkey
6+
MYAPP_RELEASE_STORE_PASSWORD=android
7+
MYAPP_RELEASE_KEY_PASSWORD=android
2.2 KB
Binary file not shown.

0 commit comments

Comments
 (0)